[TC-CLCTRL-4.1] Add python test script based on test plan #38427
Conversation
|
This test script will be validated once the app is finished and added to the CI at the same time. |
|
PR #38427: Size comparison from f6c16f6 to 8903172 Full report (3 builds for cc32xx, stm32)
|
| def desc_TC_CLCTRL_4_1(self) -> str: | ||
| return "[TC_CLCTRL_4_1] MoveTo Command Position Functionality with DUT as Server" | ||
|
|
||
| def steps_TC_CLCTRL_4_1(self) -> list[TestStep]: |
There was a problem hiding this comment.
How are the pre-conditions validated?
There was a problem hiding this comment.
Teststep change in this draft.
https://github.com/CHIP-Specifications/chip-test-plans/pull/5111
| TestStep("2c", "TH reads from the DUT the (0xFFFB) AttributeList attribute."), | ||
| TestStep("3a", "TH sends command MoveTo with Position = Signature."), | ||
| TestStep("3b", "If the attribute is supported on the cluster, TH reads from the DUT the OverallTaget attribute."), | ||
| TestStep("3c", "TH waits for PIXIT.CLCTRL.FullMotionDuration seconds."), |
There was a problem hiding this comment.
It might be more reliable to rely on the MovementCompleted event to determine that the mouvement is finished than requiring an estimate
There was a problem hiding this comment.
@mkardous-silabs Your suggestion is to integrate the Event test steps instead of the PIXIT duration?
src/python_testing/TC_CLCTRL_4_1.py
Outdated
| else: | ||
| logging.info("OverallTarget attribute is not supported on the cluster, skipping this step.") | ||
| return |
There was a problem hiding this comment.
Attribute is mandatory; if it is missing we should fail.
|
|
||
| if is_skipped == True: | ||
| logging.info("Test step skipped") | ||
| return |
There was a problem hiding this comment.
How does this translate to the rest of the test? If i am not mistaken this exits the test without completing?
There was a problem hiding this comment.
@mkardous-silabs What is the correct solution? The Testplan said it should be skip.
|
PR #38427: Size comparison from 2708ed0 to ad7cd31 Full report (3 builds for cc32xx, stm32)
|
|
PR #38427: Size comparison from 2708ed0 to 2affba9 Full report (3 builds for cc32xx, stm32)
|
|
This PR is added in the PR #39015. |
This PR adds python script for testing the Testcase TC-CLCTRL-4.1. This script should test the functionality of the MoveTo command with different positions as attribute value.
Testing