[Closure] Refactoring closure control server implementation #38545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #38545: Size comparison from 3121a4d to 0591cfa Full report (42 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
|
PR #38545: Size comparison from 3121a4d to 8a4e14f Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #38545: Size comparison from 3121a4d to 961fbcb Full report (19 builds for efr32, linux, nxp, telink)
|
src/app/clusters/closure-control-server/closure-control-cluster-delegate.h
Show resolved
Hide resolved
mkardous-silabs
approved these changes
Apr 25, 2025
src/app/clusters/closure-control-server/closure-control-cluster-logic.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/closure-control-server/closure-control-cluster-logic.cpp
Show resolved
Hide resolved
src/app/clusters/closure-control-server/closure-control-cluster-logic.cpp
Show resolved
Hide resolved
src/app/clusters/closure-control-server/closure-control-cluster-logic.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/closure-control-server/closure-control-cluster-logic.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/closure-control-server/closure-control-cluster-logic.cpp
Outdated
Show resolved
Hide resolved
bzbarsky-apple
requested changes
Apr 26, 2025
src/app/clusters/closure-control-server/closure-control-cluster-logic.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/closure-control-server/closure-control-cluster-logic.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/closure-control-server/closure-control-cluster-logic.cpp
Outdated
Show resolved
Hide resolved
E7F5
src/app/clusters/closure-control-server/closure-control-cluster-logic.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/closure-control-server/closure-control-cluster-logic.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/closure-control-server/closure-control-cluster-logic.h
Outdated
Show resolved
Hide resolved
src/app/clusters/closure-control-server/closure-control-cluster-logic.h
Outdated
Show resolved
Hide resolved
src/app/clusters/closure-control-server/closure-control-cluster-matter-context.h
Outdated
Show resolved
Hide resolved
da033db to
8ce278d
Compare
|
PR #38545: Size comparison from d23294b to 8ce278d Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #38545: Size comparison from d23294b to 84e5481 Full report (11 builds for cc13x4_26x4, cc32xx, qpg, stm32, tizen)
|
|
PR #38545: Size comparison from d23294b to 6320ea9 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
May 9, 2025
examples/closure-app/closure-common/src/ClosureControlEndpoint.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/closure-control-server/closure-control-cluster-delegate.h
Show resolved
Hide resolved
src/app/clusters/closure-control-server/closure-control-cluster-logic.cpp
Show resolved
Hide resolved
src/app/clusters/closure-control-server/closure-control-cluster-logic.cpp
Show resolved
Hide resolved
src/app/clusters/closure-control-server/closure-control-cluster-logic.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/closure-control-server/closure-control-cluster-logic.cpp
Show resolved
Hide resolved
src/app/clusters/closure-control-server/closure-control-cluster-logic.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/closure-control-server/closure-control-cluster-logic.h
Outdated
Show resolved
Hide resolved
src/app/clusters/closure-control-server/closure-control-cluster-logi
F438
c.h
Outdated
Show resolved
Hide resolved
src/app/clusters/closure-control-server/closure-control-cluster-logic.h
Outdated
Show resolved
Hide resolved
…s://github.com/senthilku/connectedhomeip into feature/closure_control_cluster_spec_final_CSA
|
The methods for reading the feature map and cluster revisions attributes appear to be missing in both the ControlClusterLogic and ControlClusterServer implementations. |
sure. will add them in next upcoming PR. |
|
PR #38545: Size comparison from 70e5039 to aeb7b5a Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
heinsaar
pushed a commit
to heinsaar/connectedhomeip
that referenced
this pull request
May 15, 2025
…chip#38545) * Closure control changes * Restyled by whitespace * Restyled by clang-format * Add Closure Control unittest cases * Restyled by whitespace * Restyled by clang-format * Resolve build error in CI * Resolve CI build errors * Add missing source files * Addressing PR comments * Adding UnitTests * Restyled by whitespace * Restyled by clang-format * Addressing PR comments * Fix build CI failures * Restyled by whitespace * Restyled by clang-format * Restyled by gn * refactoring setter for OverallState and OverallTarget * Restyled by whitespace * Restyled by clang-format * Fix CI failures * Fix CI failures * Restyled by clang-format * addressing PR comments * Restyled by whitespace * Restyled by clang-format * Apply suggestions from code review Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Addressing PR comments * Restyled by whitespace * Restyled by clang-format * rearranging private methods and variables * Restyled by clang-format * Removing delegate specific reporting in countdowntime * Update function comments * Restyled by whitespace * Restyled by clang-format * Removing Testcases related to COundowntime changes * Fix closure app failure with closure control server changes * Restyled by clang-format * Removing commented code * Added TODO for countdowntime handling * Addressing PR comments * Restyled by whitespace * Restyled by clang-format --------- Co-authored-by: sabollim <satyanaag.bollimpalli@silabs.com> Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Arun Padakanti <arunkumar.padakanti@silabs.com> Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the closure control server code implementation as per the latest spec.
Chip-spec SHA: 00a5876d51684ff38233310f254cfff280b3d05e
Testing
Build code successfully.
Unit tests are added for most of the code.