[WriteClient] Adding UnitTests for PutPreencodedAttribute and other related methods #38752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #38752: Size comparison from fae23dd to f6e4784 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tehampson
approved these changes
May 5, 2025
fad2b1b to
cd33900
Compare
|
PR #38752: Size comparison from dcecf68 to cd33900 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
May 15, 2025
|
PR #38752: Size comparison from dcecf68 to a3ca582 Full report (3 builds for cc32xx, stm32)
|
|
PR #38752: Size comparison from dcecf68 to 149d34e Increases above 0.2%:
Full report (44 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
8f7a13b to
d1639dc
Compare
|
PR #38752: Size comparison from 2ed64bc to d1639dc Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
heinsaar
pushed a commit
to heinsaar/connectedhomeip
that referenced
this pull request
May 19, 2025
…elated methods (project-chip#38752) * [WriteClient] Adding UnitTests for PutPreencodedAttribute and other related methods * Integrating Comments * Adding one more testcase in PreEncoded TLV * deacativating TestWriteChunking for fake platform * optimising: Putting repeeated testcases in a loop * Integrating comments * matching signs in assert * adding maybe_unused to variable only used in progress logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes [WriteClient][Unit Tests] Add Unit Tests for PutPreencodedAttribute #38287
WriteClient::PutPreencodedAttributeand its child methods that are used by Python and Android Controllers are not covered by Unit Tests at all.Added TestCases to cover them all.
currently WriteClient.cpp has 69.8 % coverage, these tests should put it above 90%
Testing
Unit Testing locally and CI