Return python object intead of bool value as Response for commissioning with device #38787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #38787: Size comparison from a5a6aaf to dc9bd08 Full report (27 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, telink, tizen)
|
|
PR #38787: Size comparison from a5a6aaf to 92a79ff Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
May 7, 2025
src/python_testing/matter_testing_infrastructure/chip/testing/commissioning.py
Outdated
Show resolved
Hide resolved
…eter to make it easier to use
andy31415
reviewed
May 7, 2025
src/python_testing/matter_testing_infrastructure/chip/testing/commissioning.py
Outdated
Show resolved
Hide resolved
<
8000
div class="blankslate-container">
andy31415
reviewed
May 7, 2025
src/python_testing/matter_testing_infrastructure/chip/testing/commissioning.py
Outdated
Show resolved
Hide resolved
|
PR #38787: Size comparison from a5a6aaf to 6ed53cd Full report (14 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
…iable and if success do not return empty string
andy31415
approved these changes
May 7, 2025
|
PR #38787: Size comparison from a5a6aaf to 8db0a3c Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
cjandhyala
approved these changes
May 8, 2025
|
PR #38787: Size comparison from f89539f to ac23e05 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
…b.com:Harshith-GRL/connectedhomeip into origin/standardise_response_commission_device
saurabhst
approved these changes
May 12, 2025
heinsaar
pushed a commit
to heinsaar/connectedhomeip
that referenced
this pull request
May 15, 2025
…ng with device (project-chip#38787) * Return python object intead of bool value as Response for commissioning with device * added docstrings PairingStatus class * Restyled by autopep8 * set the PairingStatus to False when exception occurs * Updated PairingStatus class to evaluate to true without success parameter to make it easier to use * bool expression validation is made directly instead of storing in variable and if success do not return empty string * added new line to re-start CI job --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: cjandhyala <68604034+cjandhyala@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
commission_device()returns booleanTrueorFalsebased on the commissioning with device, there is a small issue in the code. If commissioning fails then the reason for failure is only logged to the console which makes is insufficient for certain scenario where we want to store the reason for failure to commission with device.Solution
Create a Class called
PairingStatusto hold the commissioning status and if any exception occurs during paring store it in the class object.This approach will standerise the way response is returned to the calling function.
Testing
Performed bootstrap build of the code and built python environment tested the code with cert test src/python_testing/TC_EPREF_2_1.py works as expected
Fix for issue #38359