[Darwin][Network.framework] Update the interface monitor such that it… #38983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… returns a nw_interface_t instead of the interface index
|
PR #38983: Size comparison from 9189b28 to 19d2150 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
approved these changes
May 16, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR updates the InterfacesMonitor API to return nw_interface_t objects instead of numeric interface indices so that callers can access properties directly from the nw_interface_t.
- Replaced numeric interface IDs with nw_interface_t across InterfacesMonitor and DnssdHostNameRegistrar.
- Updated logging and address retrieval functions to use nw_interface_get_index() for consistency.
- Adjusted type definitions in the header files to support the new nw_interface_t based API.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/platform/Darwin/inet/InterfacesMonitor.mm | Updated LogDetails, GetInterfaceAddresses, and monitor creation to use nw_interface_t. |
| src/platform/Darwin/inet/InterfacesMonitor.h | Changed InetInterface and Inet6Interface typedefs and declared new utility functions. |
| src/platform/Darwin/DnssdHostNameRegistrar.h | Updated interface registration to extract the index from nw_interface_t. |
Comments suppressed due to low confidence (1)
src/platform/Darwin/inet/InterfacesMonitor.h:51
- The parameter name 'searchLoopBackOnly' in the header differs in casing from its implementation ('searchLoopbackOnly'). Standardizing the naming will improve clarity and consistency.
void EnumeratePathInterfaces(nw_path_t path, InetInterfacesVector & out4, Inet6InterfacesVector & out6, bool searchLoopBackOnly);
bzbarsky-apple
approved these changes
May 16, 2025
|
fast track: platform-specific changes made by platform maintainer. |
heinsaar
pushed a commit
to heinsaar/connectedhomeip
that referenced
this pull request
May 19, 2025
… returns a nw_interface_t instead of the interface index (project-chip#38983)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… returns a nw_interface_t instead of the interface index
The
Network.frameworkonly usesnw_interface_tobjects—you can’t round-trip back to anw_interface_tfrom a numeric index. This change updates ourInterfacesMonitorAPI so that it hands callers the actualnw_interface_t(and lets them extract name, index, type, etc.) rather than a bare index.Testing
Our CI pipeline verifies that this change works as intended.