8000 Bump some cluster revisions in examples by tcarmelveilleux · Pull Request #38905 · project-chip/connectedhomeip · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bump some cluster revisions in examples #38905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 13, 2025
Merged

Bump some cluster revisions in examples #38905

merged 7 commits into from
May 13, 2025

Conversation

tcarmelveilleux
Copy link
Contributor
@tcarmelveilleux tcarmelveilleux commented May 13, 2025 •
edited
Loading

Changes

  • Update General Commissioning cluster version in XML to always include rev 2 with external storage
  • Update the version of Identify to match spec (there is an issue to bump to 6)
  • Update the version of BridgedBasicInformation to 5
  • Updated device type revisions of Aggregator, Root Node and Dishwasher to latest

Testing

  • DeviceConformance passes on more examples
  • Fixed TestDescriptorCluster
  • CI still passes

@tcarmelveilleux tcarmelveilleux requested review from a team as code owners May 13, 2025 14:50
@github-actions GitHub Actions
Copy link
github-actions bot commented May 13, 2025 •
edited
Loading

PR #38905: Size comparison from f4d171a to 79b868c

Full report (14 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
platform target config section f4d171a 79b868c change % change
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 820132 820180 48 0.0
RAM 120208 120208 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 830184 830232 48 0.0
RAM 125376 125376 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 778408 778456 48 0.0
RAM 113780 113780 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 762716 762764 48 0.0
RAM 113988 113988 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 548986 549034 48 0.0
RAM 205192 205192 0 0.0
lock CC3235SF_LAUNCHXL FLASH 579674 579722 48 0.0
RAM 205376 205376 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 919184 919232 48 0.0
RAM 167328 167328 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 911188 911208 20 0.0
RAM 145572 145572 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 856408 856456 48 0.0
RAM 141091 141091 0 0.0
qpg lighting-app qpg6105+debug FLASH 666740 666788 48 0.0
RAM 105172 105172 0 0.0
lock-app qpg6105+debug FLASH 625144 625192 48 0.0
RAM 99792 99792 0 0.0
stm32 light STM32WB5MM-DK FLASH 464484 464532 48 0.0
RAM 141416 141416 0 0.0
tizen all-clusters-app arm unknown 5212 5216 4 0.1
FLASH 1812112 1812152 40 0.0
RAM 94832 94832 0 0.0
chip-tool-ubsan arm unknown 20600 20600 0 0.0
FLASH 20822726 20822726 0 0.0
RAM 9059864 9059864 0 0.0

@github-actions GitHub Actions
Copy link
github-actions bot commented May 13, 2025 •
edited
Loading

PR #38905: Size comparison from f4d171a to b5a0946

Full report (46 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, linux, nrfconnect, psoc6, qpg, stm32, telink, tizen)
platform target config section f4d171a b5a0946 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1101678 1101678 0 0.0
RAM 179002 179002 0 0.0
bl702 lighting-app bl702+eth FLASH 656472 656472 0 0.0
RAM 134941 134941 0 0.0
bl702+wifi FLASH 833494 833750 256 0.0
RAM 124481 124481 0 0.0
bl706+mfd+rpc+littlefs FLASH 1066582 1066582 0 0.0
RAM 117349 117349 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 896152 896152 0 0.0
RAM 105688 105688 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 979926 979926 0 0.0
RAM 109836 109836 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 820132 820180 48 0.0
RAM 120208 120208 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 830184 830232 48 0.0
RAM 125376 125376 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 778408 778456 48 0.0
RAM 113780 113780 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 762716 762764 48 0.0
RAM 113988 113988 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 548986 549034 48 0.0
RAM 205192 205192 0 0.0
lock CC3235SF_LAUNCHXL FLASH 579674 579722 48 0.0
RAM 205376 205376 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 661645 661693 48 0.0
RAM 77236 77236 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 681497 681545 48 0.0
RAM 79876 79876 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 681497 681545 48 0.0
RAM 79876 79876 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 638437 638485 48 0.0
RAM 72304 72304 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 622933 622981 48 0.0
RAM 73532 73532 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 642577 642625 48 0.0
RAM 76084 76084 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 642577 642625 48 0.0
RAM 76084 76084 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 642341 642389 48 0.0
RAM 76532 76532 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 662057 662105 48 0.0
RAM 79084 79084 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 662057 662105 48 0.0
RAM 79084 79084 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 618569 618617 48 0.0
RAM 70636 70636 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 638421 638469 48 0.0
RAM 73268 73268 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 638421 638469 48 0.0
RAM 73268 73268 0 0.0
linux chip-tool-ipv6only arm64 unknown 40328 40328 0 0.0
FLASH 12572560 12572560 0 0.0
RAM 691456 691456 0 0.0
thermostat-no-ble arm64 unknown 9608 9616 8 0.1
FLASH 4224864 4224912 48 0.0
RAM 230864 230864 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 919184 919232 48 0.0
RAM 167328 167328 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 911188 911208 20 0.0
RAM 145572 145572 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 856408 856456 48 0.0
RAM 141091 141091 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1665236 1665268 32 0.0
RAM 212328 212328 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1569724 1569764 40 0.0
RAM 208504 208504 0 0.0
light cy8ckit_062s2_43012 FLASH 1445196 1445228 32 0.0
RAM 197224 197224 0 0.0
lock cy8ckit_062s2_43012 FLASH 1475196 1475236 40 0.0
RAM 224936 224936 0 0.0
qpg lighting-app qpg6105+debug FLASH 666740 666788 48 0.0
RAM 105172 105172 0 0.0
lock-app qpg6105+debug FLASH 625144 625192 48 0.0
RAM 99792 99792 0 0.0
stm32 light STM32WB5MM-DK FLASH 464484 464532 48 0.0
RAM 141416 141416 0 0.0
telink bridge-app tl7218x FLASH 693498 693534 36 0.0
RAM 101832 101832 0 0.0
light-app-ota-compress-lzma-factory-data tl3218x FLASH 772884 772920 36 0.0
RAM 49984 49984 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 779990 780026 36 0.0
RAM 109164 109164 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 702258 702294 36 0.0
RAM 62544 62544 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 740212 740248 36 0.0
RAM 85724 85724 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 606312 606348 36 0.0
RAM 119380 119380 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 815300 815340 40 0.0
RAM 107432 107432 0 0.0
tizen all-clusters-app arm unknown 5212 5216 4 0.1
FLASH 1812112 1812152 40 0.0
RAM 94832 94832 0 0.0
chip-tool-ubsan arm unknown 20600 20600 0 0.0
FLASH 20822726 20822726 0 0.0
RAM 9059864 9059864 0 0.0

@andy31415
Copy link
Contributor

@tcarmelveilleux - we should probably mark all revision for general commissioning as external now and save 1 byte of RAM everywhere.

@github-actions github-actions bot added the tests label May 13, 2025
@github-actions GitHub Actions
Copy link
github-actions bot commented May 13, 2025 •
edited
Loading

PR #38905: Size comparison from f4d171a to 4250e4a

Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section f4d171a 4250e4a change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1101678 1101678 0 0.0
RAM 179002 178994 -8 -0.0
bl702 lighting-app bl702+eth FLASH 656472 656472 0 0.0
RAM 134941 134941 0 0.0
bl702+wifi FLASH 833494 833750 256 0.0
RAM 124481 124481 0 0.0
bl706+mfd+rpc+littlefs FLASH 1066582 1066582 0 0.0
RAM 117349 117349 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 896152 896152 0 8000 0.0
RAM 105688 105688 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 979926 979926 0 0.0
RAM 109836 109836 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 820132 820180 48 0.0
RAM 120208 120208 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 830184 830232 48 0.0
RAM 125376 125376 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 778408 778456 48 0.0
RAM 113780 113780 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 762716 762764 48 0.0
RAM 113988 113988 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 548986 549034 48 0.0
RAM 205192 205192 0 0.0
lock CC3235SF_LAUNCHXL FLASH 579674 579722 48 0.0
RAM 205376 205376 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 661645 661693 48 0.0
RAM 77236 77236 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 681497 681545 48 0.0
RAM 79876 79876 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 681497 681545 48 0.0
RAM 79876 79876 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 638437 638485 48 0.0
RAM 72304 72304 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 622933 622981 48 0.0
RAM 73532 73532 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 642577 642625 48 0.0
RAM 76084 76084 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 642577 642625 48 0.0
RAM 76084 76084 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 642341 642389 48 0.0
RAM 76532 76532 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 662057 662105 48 0.0
RAM 79084 79084 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 662057 662105 48 0.0
RAM 79084 79084 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 618569 618617 48 0.0
RAM 70636 70628 -8 -0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 638421 638469 48 0.0
RAM 73268 73260 -8 -0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 638421 638469 48 0.0
RAM 73268 73260 -8 -0.0
efr32 lock-app BRD4187C FLASH 945084 945116 32 0.0
RAM 132024 132024 0 0.0
BRD4338a FLASH 771144 771176 32 0.0
RAM 173248 173248 0 0.0
window-app BRD4187C FLASH 1037112 1037144 32 0.0
RAM 128160 128160 0 0.0
esp32 all-clusters-app c3devkit DRAM 103328 103320 -8 -0.0
FLASH 1805438 1805474 36 0.0
IRAM 83846 83846 0 0.0
m5stack DRAM 121932 121932 0 0.0
FLASH 1770586 1770626 40 0.0
IRAM 117043 117043 0 0.0
linux air-purifier-app debug unknown 4848 4848 0 0.0
FLASH 2786914 2786968 54 0.0
RAM 115032 115032 0 0.0
all-clusters-app debug unknown 5656 5656 0 0.0
FLASH 6340606 6340660 54 0.0
RAM 533112 533112 0 0.0
all-clusters-minimal-app debug unknown 5528 5528 0 0.0
FLASH 5444898 5444952 54 0.0
RAM 225000 225000 0 0.0
bridge-app debug unknown 5560 5560 0 0.0
FLASH 4761334 4761388 54 0.0
RAM 204640 204640 0 0.0
camera-app debug unknown 8856 8856 0 0.0
FLASH 6883387 6883451 64 0.0
RAM 226168 226168 0 0.0
camera-controller debug unknown 9240 9240 0 0.0
FLASH 14309675 14309675 0 0.0
RAM 658416 658416 0 0.0
chip-tool debug unknown 6256 6256 0 0.0
FLASH 14591323 14591323 0 0.0
RAM 645168 645168 0 0.0
chip-tool-ipv6only arm64 unknown 40328 40328 0 0.0
FLASH 12572560 12572560 0 0.0
RAM 691456 691456 0 0.0
fabric-admin debug unknown 5936 5936 0 0.0
FLASH 12668741 12668741 0 0.0
RAM 644528 644528 0 0.0
fabric-bridge-app debug unknown 4808 4808 0 0.0
FLASH 4578372 4578426 54 0.0
RAM 190704 190704 0 0.0
fabric-sync debug unknown 5064 5064 0 0.0
FLASH 5718629 5718677 48 0.0
RAM 486560 486560 0 0.0
lighting-app debug+rpc+ui unknown 6264 6264 0 0.0
FLASH 5641729 5641777 48 0.0
RAM 207176 207176 0 0.0
lock-app debug unknown 5496 5496 0 0.0
FLASH 4813668 4813722 54 0.0
RAM 194472 194440 -32 -0.0
ota-provider-app debug unknown 4848 4848 0 0.0
FLASH 4439346 4439400 54 0.0
RAM 183888 183888 0 0.0
ota-requestor-app debug unknown 4800 4800 0 0.0
FLASH 4567110 4567164 54 0.0
RAM 187792 187760 -32 -0.0
shell debug unknown 4272 4272 0 0.0
FLASH 3078316 3078364 48 0.0
RAM 148072 148072 0 0.0
thermostat-no-ble arm64 unknown 9608 9616 8 0.1
FLASH 4224864 4224912 48 0.0
RAM 230864 230864 0 0.0
tv-app debug unknown 5832 5832 0 0.0
FLASH 6074037 6074101 64 0.0
RAM 610984 610984 0 0.0
tv-casting-app debug unknown 5416 5416 0 0.0
FLASH 12780861 12780909 48 0.0
RAM 765456 765456 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 919184 919232 48 0.0
RAM 167328 167326 -2 -0.0
nrf7002dk_nrf5340_cpuapp FLASH 911188 911208 20 0.0
RAM 145572 145570 -2 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 856408 856456 48 0.0
RAM 141091 141089 -2 -0.0
nxp contact k32w0+release FLASH 591872 591920 48 0.0
RAM 72848 72848 0 0.0
mcxw71+release FLASH 624632 624680 48 0.0
RAM 63188 63188 0 0.0
light k32w0+release FLASH 617788 617836 48 0.0
RAM 72144 72144 0 0.0
k32w1+release FLASH 709104 709152 48 0.0
RAM 72036 72036 0 0.0
lock mcxw71+release FLASH 774160 774208 48 0.0
RAM 67612 67612 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1665236 1665268 32 0.0
RAM 212328 212328 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1569724 1569764 40 0.0
RAM 208504 208504 0 0.0
light cy8ckit_062s2_43012 FLASH 1445196 1445228 32 0.0
RAM 197224 197216 -8 -0.0
lock cy8ckit_062s2_43012 FLASH 1475196 1475236 40 0.0
RAM 224936 224936 0 0.0
qpg lighting-app qpg6105+debug FLASH 666740 666788 48 0.0
RAM 105172 105164 -8 -0.0
lock-app qpg6105+debug FLASH 625144 625192 48 0.0
RAM 99792 99792 0 0.0
stm32 light STM32WB5MM-DK FLASH 464484 464532 48 0.0
RAM 141416 141416 0 0.0
telink bridge-app tl7218x FLASH 693498 693534 36 0.0
RAM 101832 101828 -4 -0.0
light-app-ota-compress-lzma-factory-data tl3218x FLASH 772884 772920 36 0.0
RAM 49984 49980 -4 -0.0
light-app-ota-shell-factory-data tl7218x FLASH 779990 780026 36 0.0
RAM 109164 109160 -4 -0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 702258 702294 36 0.0
RAM 62544 62544 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 740212 740248 36 0.0
RAM 85724 85724 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 606312 606348 36 0.0
RAM 119380 119376 -4 -0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 815300 815340 40 0.0
RAM 107432 107428 -4 -0.0
tizen all-clusters-app arm unknown 5212 5216 4 0.1
FLASH 1812112 1812152 40 0.0
RAM 94832 94832 0 0.0
chip-tool-ubsan arm unknown 20600 20600 0 0.0
FLASH 20822726 20822726 0 0.0
RAM 9059864 9059864 0 0.0

@mergify mergify bot merged commit fdacd16 into project-chip:master May 13, 2025
73 checks passed
heinsaar pushed a commit to heinsaar/connectedhomeip that referenced this pull request May 15, 2025
@tcarmelveilleux @restyled-commits @heinsaar
Bump some cluster revisions in examples (project-chip#38905)
4287551 
* Update General Commissioning Version in XML

* ZAP regen

* Restyled by clang-format

* Remove invalid constraints from matter-devices.xml

* Bump RootNode/Aggregator/Dishwasher dev type revs and regen

* Made ClusterRevision External on General Commissioning

* Fix TestDescriptorCluster

---------

Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@ReneJosefsen ReneJosefsen ReneJosefsen approved these changes

Assignees
No one assigned
Labels
app controller examples review - approved tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tcarmelveilleux @andy31415 @ReneJosefsen @restyled-commits
0