Use SOURCE_DATE_EPOCH from environment if present #38929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the script that generates FirmwareBuildTime.h to use the timestamp from the SOURCE_DATE_EPOCH environment if it is present and ahead of the time stored in the fallback_last_known_good_time file. This allows the timestamp to be easily picked up from build systems that follow this standard for supplying the source timestamp (https://reproducible-builds.org/specs/source-date-epoch/) Also do the conversion between POSIX and Matter epoch times by simple offsetting, instead of dealing with time zones and calendars.
|
PR #38929: Size comparison from fdacd16 to a278dcd Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tcarmelveilleux
approved these changes
May 14, 2025
arkq
approved these changes
May 14, 2025
heinsaar
pushed a commit
to heinsaar/connectedhomeip
that referenced
this pull request
May 15, 2025
Update the script that generates FirmwareBuildTime.h to use the timestamp from the SOURCE_DATE_EPOCH environment if it is present and ahead of the time stored in the fallback_last_known_good_time file. This allows the timestamp to be easily picked up from build systems that follow this standard for supplying the source timestamp (https://reproducible-builds.org/specs/source-date-epoch/) Also do the conversion between POSIX and Matter epoch times by simple offsetting, instead of dealing with time zones and calendars.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the script that generates FirmwareBuildTime.h to use the timestamp from the SOURCE_DATE_EPOCH environment if it is present and ahead of the time stored in the fallback_last_known_good_time file. This allows the timestamp to be easily picked up from build systems that follow this standard for supplying the source timestamp (https://reproducible-builds.org/specs/source-date-epoch/)
Also do the conversion between POSIX and Matter epoch times by simple
offsetting, instead of dealing with time zones and calendars.
Testing
Tested locally that
SOURCE_DATE_EPOCHis picked up correctly, and also that the script still operates correctly with the--use-current-timeand--update-fallback-time-in-fileoptions.