[Darwin] Unit test for #39003 #39041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #39041: Size comparison from 9f95d75 to 0740e59 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
woody-apple
approved these changes
May 17, 2025
kiel-apple
reviewed
May 17, 2025
Co-authored-by: Kiel Oleson <kielo@apple.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new unit test to validate the device resubscription behavior and removes redundant code from the resubscription logic in the CHIP framework. Key changes include:
- Adding unit test test048_MTRDeviceResubscribeOnSubscriptionPool in MTRDeviceTests.m.
- Introducing a new unit test-only method unitTestSyncRunOnDeviceQueue and a subscriptionMaxIntervalOverride property in MTRDeviceTestDelegate.
- Modifying the resubscription logic in MTRDevice_Concrete.mm to remove duplicated code and adjust the subscription pool clearing behavior.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/darwin/Framework/CHIPTests/TestHelpers/MTRTestDeclarations.h | Added two new test-only method declarations. |
| src/darwin/Framework/CHIPTests/TestHelpers/MTRDeviceTestDelegate.m | Added a check for subscriptionMaxIntervalOverride. |
| src/darwin/Framework/CHIPTests/TestHelpers/MTRDeviceTestDelegate.h | Added subscriptionMaxIntervalOverride property. |
| src/darwin/Framework/CHIPTests/MTRDeviceTests.m | Introduced a new unit test for resubscription behavior. |
| src/darwin/Framework/CHIP/MTRDevice_Concrete.mm | Updated resubscription flow and added a debug-only test method. |
kiel-apple
approved these changes
May 17, 2025
|
PR #39041: Size comparison from 9f95d75 to d568ca8 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
heinsaar
pushed a commit
to heinsaar/connectedhomeip
that referenced
this pull request
May 19, 2025
* [Darwin] Unit test for project-chip#39003 * Update src/darwin/Framework/CHIPTests/MTRDeviceTests.m Co-authored-by: Kiel Oleson <kielo@apple.com> --------- Co-authored-by: Justin Wood <woody@apple.com> Co-authored-by: Kiel Oleson <kielo@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39004
Added unit test, and also removed unnecessary code in #39003.
Testing
The new test should pass.