-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[camera] Use common configs to create a GStreamer pipeline #39009
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yufengwangca
merged 2 commits into
project-chip:master
from
yufengwangca:pr/camera/config
May 16, 2025
Merged
[camera] Use common configs to create a GStreamer pipeline #39009
yufengwangca
merged 2 commits into
project-chip:master
from
yufengwangca:pr/camera/config
May 16, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f53c089
to
248d586
Compare
PR #39009: Size comparison from 7e868e7 to 248d586 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
pidarped
approved these changes
May 16, 2025
marktrayer
reviewed
May 16, 2025
marktrayer
approved these changes
May 16, 2025
PR #39009: Size comparison from 7e868e7 to b833540 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
heinsaar
pushed a commit
to heinsaar/connectedhomeip
that referenced
this pull request
May 19, 2025
…hip#39009) * Use common configs to create a GStreamer pipeline * Don't mix aspect ratios between the min and max resolutions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The camera settings were previously hard‑coded to a single configuration that fails on all three of the test cameras I have. This commit begins our move toward auto‑detecting device capabilities and building the GStreamer pipeline dynamically.
As a transitional step we switch to a “safe‑default” configuration that should work with the majority of off‑the‑shelf webcams.
This approach gives broad compatibility today while paving the way for full hardware‑driven configuration in the next phase.
Testing
Start video from camera -controller
> cameraavstreammanagement video-stream-allocate 3 0 30 120 '{"width": 320, "height": 240}' '{"width": 640, "height": 480}' 10000 10000 1 10 1 1
View video stream from another terminal using gst-launch-1.0