8000 [Darwin][CI] Fallback to SIGKILL after 10 seconds if terminate fails … by vivien-apple · Pull Request #39020 · project-chip/connectedhomeip · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Darwin][CI] Fallback to SIGKILL after 10 seconds if terminate fails … #39020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2025
Merged

[Darwin][CI] Fallback to SIGKILL after 10 seconds if terminate fails … #39020

merged 1 commit into from
May 16, 2025

Conversation

vivien-apple
Copy link
Contributor

…for NSTask cleanup

Description

Ensure NSTask subprocesses are reliably cleaned up in CI by sending SIGKILL if they don’t exit after terminate.

Testing

If this doesn’t work, we’ll know — because there will be zombies shambling around in CI. 🧟‍♂️

@vivien-apple vivien-apple self-assigned this May 16, 2025
@vivien-apple vivien-apple requested a review from a team as a code owner May 16, 2025 11:11
@github-actions GitHub Actions
Copy link
github-actions bot commented May 16, 2025 •
edited
Loading

PR #39020: Size comparison from 2ed64bc to bd4629e

Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 2ed64bc bd4629e change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1103314 1103314 0 0.0
RAM 179082 179082 0 0.0
bl702 lighting-app bl702+eth FLASH 656544 656544 0 0.0
RAM 135041 135041 0 0.0
bl702+wifi FLASH 834054 834054 0 0.0
RAM 124597 124597 0 0.0
bl706+mfd+rpc+littlefs FLASH 1066594 1066594 0 0.0
RAM 117429 117429 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 895530 895530 0 0.0
RAM 105732 105732 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 979618 979618 0 0.0
RAM 109932 109932 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 821764 821764 0 0.0
RAM 120296 120296 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 831632 831632 0 0.0
RAM 125448 125448 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 779192 779192 0 0.0
RAM 113844 113844 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 763412 763412 0 0.0
RAM 114060 114060 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 549646 549646 0 0.0
RAM 205264 205264 0 0.0
lock CC3235SF_LAUNCHXL FLASH 581062 581062 0 0.0
RAM 205456 205456 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 662901 662901 0 0.0
RAM 77308 77308 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 682753 682753 0 0.0
RAM 79948 79948 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 682753 682753 0 0.0
RAM 79948 79948 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 639693 639693 0 0.0
RAM 72376 72376 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 624053 624053 0 0.0
RAM 73604 73604 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 643689 643689 0 0.0
RAM 76156 76156 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 643689 643689 0 0.0
RAM 76156 76156 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 643405 643405 0 0.0
RAM 76604 76604 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 663121 663121 0 0.0
RAM 79156 79156 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 663121 663121 0 0.0
RAM 79156 79156 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 619577 619577 0 0.0
RAM 70708 70708 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 639429 639429 0 0.0
RAM 73340 73340 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 639429 639429 0 0.0
RAM 73340 73340 0 0.0
efr32 lock-app BRD4187C FLASH 946164 946164 0 0.0
RAM 132096 132096 0 0.0
BRD4338a FLASH 772984 772984 0 0.0
RAM 173320 173320 0 0.0
window-app BRD4187C FLASH 1038808 1038808 0 0.0
RAM 128232 128232 0 0.0
esp32 all-clusters-app c3devkit DRAM 103408 103408 0 0.0
FLASH 1808078 1808078 0 0.0
IRAM 83846 83846 0 0.0
m5stack DRAM 122028 122028 0 0.0
FLASH 1774154 1774154 0 0.0
IRAM 117043 117043 0 0.0
linux air-purifier-app debug unknown 4848 4848 0 0.0
FLASH 2793962 2793962 0 0.0
RAM 115288 115288 0 0.0
all-clusters-app debug unknown 5656 5656 0 0.0
FLASH 6360072 6360072 0 0.0
RAM 533848 533848 0 0.0
all-clusters-minimal-app debug unknown 5528 5528 0 0.0
FLASH 5462572 5462572 0 0.0
RAM 225624 225624 0 0.0
bridge-app debug unknown 5560 5560 0 0.0
FLASH 4770768 4770768 0 0.0
RAM 205008 205008 0 0.0
camera-app debug unknown 8856 8856 0 0.0
FLASH 6896315 6896315 0 0.0
RAM 226680 226680 0 0.0
camera-controller debug unknown 9240 9240 0 0.0
FLASH 14391979 14391979 0 0.0
RAM 661552 661552 0 0.0
chip-tool debug unknown 6256 6256 0 0.0
FLASH 14674715 14674715 0 0.0
RAM 648288 648288 0 0.0
chip-tool-ipv6only arm64 unknown 40328 40328 0 0.0
FLASH 12625408 12625408 0 0.0
RAM 694576 694576 0 0.0
fabric-admin debug unknown 5936 5936 0 0.0
FLASH 12751055 12751055 0 0.0
RAM 647648 647648 0 0.0
fabric-bridge-app debug unknown 4808 4808 0 0.0
FLASH 4587370 4587370 0 0.0
RAM 191088 191088 0 0.0
fabric-sync debug unknown 5064 5064 0 0.0
FLASH 5733509 5733509 0 0.0
RAM 487200 487200 0 0.0
lighting-app debug+rpc+ui unknown 6264 6264 0 0.0
FLASH 5651041 5651041 0 0.0
RAM 207576 207576 0 0.0
lock-app debug unknown 5496 5496 0 0.0
FLASH 4824426 4824426 0 0.0
RAM 194872 194872 0 0.0
ota-provider-app debug unknown 4848 4848 0 0.0
FLASH 4446268 4446268 0 0.0
RAM 184176 184176 0 0.0
ota-requestor-app debug unknown 4800 4800 0 0.0
FLASH 4575872 4575872 0 0.0
RAM 188080 188080 0 0.0
shell debug unknown 4272 4272 0 0.0
FLASH 3095260 3095260 0 0.0
RAM 148632 148632 0 0.0
thermostat-no-ble arm64 unknown 9624 9624 0 0.0
FLASH 4234176 4234176 0 0.0
RAM 231264 231264 0 0.0
tv-app debug unknown 5832 5832 0 0.0
FLASH 6092325 6092325 0 0.0
RAM 611672 611672 0 0.0
tv-casting-app debug unknown 5416 5416 0 0.0
FLASH 12873933 12873933 0 0.0
RAM 769072 769072 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 921580 921580 0 0.0
RAM 167398 167398 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 913312 913312 0 0.0
RAM 145642 145642 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 858688 858688 0 0.0
RAM 141161 141161 0 0.0
nxp contact k32w0+release FLASH 592960 592960 0 0.0
RAM 72928 72928 0 0.0
mcxw71+release FLASH 625832 625832 0 0.0
RAM 63268 63268 0 0.0
light k32w0+release FLASH 619100 619100 0 0.0
RAM 72224 72224 0 0.0
k32w1+release FLASH 710552 710552 0 0.0
RAM 72116 72116 0 0.0
lock mcxw71+release FLASH 775632 775632 0 0.0
RAM 67692 67692 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1669252 1669252 0 0.0
RAM 212408 212408 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1573340 1573340 0 0.0
RAM 208592 208592 0 0.0
light cy8ckit_062s2_43012 FLASH 1447540 1447540 0 0.0
RAM 197296 197296 0 0.0
lock cy8ckit_062s2_43012 FLASH 1477444 1477444 0 0.0
RAM 225016 225016 0 0.0
qpg lighting-app qpg6105+debug FLASH 668332 668332 0 0.0
RAM 105244 105244 0 0.0
lock-app qpg6105+debug FLASH 626528 626528 0 0.0
RAM 99872 99872 0 0.0
stm32 light STM32WB5MM-DK FLASH 466004 466004 0 0.0
RAM 141496 141496 0 0.0
telink bridge-app tl7218x FLASH 694620 694620 0 0.0
RAM 101908 101908 0 0.0
light-app-ota-compress-lzma-factory-data tl3218x FLASH 774330 774330 0 0.0
RAM 50060 50060 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 781436 781436 0 0.0
RAM 109232 109232 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 703582 703582 0 0.0
RAM 62624 62624 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 741536 741536 0 0.0
RAM 85796 85796 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 607758 607758 0 0.0
RAM 119448 119448 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 816746 816750 4 0.0
RAM 107500 107500 0 0.0
tizen all-clusters-app arm unknown 5224 5224 0 0.0
FLASH 1822448 1822448 0 0.0
RAM 95164 95164 0 0.0
chip-tool-ubsan arm unknown 20600 20600 0 0.0
FLASH 20893806 20893806 0 0.0
RAM 9084072 9084072 0 0.0

@mergify mergify bot merged commit f1830ce into project-chip:master May 16, 2025
71 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in [Platform] Darwin May 16, 2025
heinsaar pushed a commit to heinsaar/connectedhomeip that referenced this pull request May 19, 2025
@vivien-apple @heinsaar
[Darwin][CI] Fallback to SIGKILL after 10 seconds if terminate fails …
314e88b 
…for NSTask cleanup (project-chip#39020)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

Assignees

@vivien-apple vivien-apple

Labels
darwin fast track review - pending
Projects
[Platform] Darwin
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vivien-apple @woody-apple
0