[Darwin] MTRDevice diagnostic log transfer state improvements #39033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #39033: Size comparison from 386263d to 92a60b0 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #39033: Size comparison from 386263d to a6f82de Full report (14 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
woody-apple
approved these changes
May 16, 2025
kiel-apple
commented
May 16, 2025
|
PR #39033: Size comparison from 386263d to 72939b5 Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
anush-apple
reviewed
May 16, 2025
heinsaar
pushed a commit
to heinsaar/connectedhomeip
that referenced
this pull request
May 19, 2025
…t-chip#39033) * switch to std::lock_guard for locking * implement `diagnosticLogTransferInProgress` accessor in `MTRDevice_XPC` * internal property change must notify delegate * populate diagnostic log transfer state in `_internalProperties`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os_unfair_lockuse withstd::lock_guardMTRDevice_XPCTesting
MTRDevice_Concretetested on real device as tested in [darwin] expose diagnostic log download state #39002MTRDevice_XPCtested on real device[self _setInternalState:newState];ofnewStateto validateMTRDeviceInternalPropertyDiagnosticLogTransferInProgressalternates 0/1 as transfers are begun and end, settling on 0.