Move CommissionDeviceTest class to commissioning.py #39478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Added class global_stash to have stashed attirbutes outside matter_testing. Updated runner imports.
There was a problem hiding this comment.
Code Review
This pull request refactors the CommissionDeviceTest class and related utilities into commissioning.py, addressing circular dependency issues. The global_stash.py module is introduced to handle Mobly's limitations with ctypes objects. The changes are well-structured. The suggestions focus on improving type hinting and avoiding shadowing built-in names.
src/python_testing/matter_testing_infrastructure/chip/testing/commissioning.py
Outdated
Show resolved
Hide resolved
src/python_testing/matter_testing_infrastructure/chip/testing/global_stash.py
Outdated
Show resolved
Hide resolved
|
PR #39478: Size comparison from 55d3763 to a96e714 Full report (3 builds for cc32xx, stm32)
|
|
PR #39478: Size comparison from c1d1dea to 0bc005b Increases above 0.2%:
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
r-recchia
approved these changes
Jun 11, 2025
arkq
approved these changes
Jun 12, 2025
src/python_testing/matter_testing_infrastructure/chip/testing/commissioning.py
Outdated
Show resolved
Hide resolved
src/python_testing/matter_testing_infrastructure/chip/testing/matter_testing.py
Outdated
Show resolved
Hide resolved
src/python_testing/matter_testing_infrastructure/chip/testing/matter_testing.py
Outdated
Show resolved
Hide resolved
|
PR #39478: Size comparison from be1cfb1 to 348fc0d Full report (3 builds for cc32xx, stm32)
|
…ad_info for get_setup_payload_info_config at commissioning.py
|
PR #39478: Size comparison from be1cfb1 to cbcf789 Full report (11 builds for cc13x4_26x4, cc32xx, qpg, stm32, tizen)
|
|
PR #39478: Size comparison from be1cfb1 to 1ddeb96 Increases above 0.2%:
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
cecille
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains the work to move the python class CommissioningDeviceTest from
matter_testing.pytocommissioning.py. This class works as a mobly TestCase class to commission the device if is needed, this class has a test in the methodtest_run_commissioningto commission the device under test.Actions taken
get_setup_payload_infoto commissioning.py to avoid circular imports.Related issues
##Fixes: project-chip/matter-test-scripts#589
Testing
In order to test the changes I run a few tests using the Linux apps and the ESP32 M5 Stack to verify on-network commissioning works and device commissioning.
Build the linux application and run the one of the test using commissioning on-network
Flash the device with the LIGTHING_APP
Run the script and commissioning should be done properly.