increasing UT coverage for src/lib/address_resolve. #39507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Code Review
Increased unit tests coverage for src/lib/address_resolve, focusing on NodeLookupHandle timing logic and Resolver interactions. The tests are well-structured using mocks and fixtures. The OperationalNodeResolved test should initialize ResolvedNodeData with a matching PeerId and add assertions to verify state changes or listener callbacks.
src/lib/address_resolve/tests/TestAddressResolve_DefaultImpl.cpp
Outdated
Show resolved
Hide resolved
25a1719 to
4cb89cd
Compare
|
PR #39507: Size comparison from 6d6400a to 4cb89cd Full report (52 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
487ee15 to
50c2101
Compare
|
PR #39507: Size comparison from 5a270bd to 50c2101 Full report (43 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, psoc6, qpg, stm32, telink, tizen)
|
a21d86f to
6b4bef5
Compare
andy31415
reviewed
Jun 12, 2025
src/lib/address_resolve/tests/TestAddressResolve_DefaultImpl.cpp
Outdated
Show resolved
Hide resolved
andy31415
approved these changes
Jun 12, 2025
|
PR #39507: Size comparison from 5a270bd to 6b4bef5 Increases above 0.2%:
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
6b4bef5 to
49abd33
Compare
|
PR #39507: Size comparison from 57827d7 to 9c3bf13 Full report (24 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, qpg, stm32, telink, tizen)
|
heinsaar
reviewed
Jun 13, 2025
src/lib/address_resolve/tests/TestAddressResolve_DefaultImpl.cpp
Outdated
Show resolved
Hide resolved
|
PR #39507: Size comparison from 57827d7 to 071232b Increases above 0.2%:
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #39507: Size comparison from b764a9d to bf10cae Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
bf10cae to
216eb3b
Compare
|
PR #39507: Size comparison from f38f1de to 216eb3b Full report (67 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
216eb3b to
c8ab24c
Compare
|
PR #39507: Size comparison from 5e089d1 to c8ab24c Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
Damian-Nordic
requested changes
Jul 8, 2025
Restyled by clang-format
c4adc46 to
4854c28
Compare
Damian-Nordic
approved these changes
Jul 8, 2025
|
PR #39507: Size comparison from 050f895 to 4854c28 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
dsavitsky-dsr
pushed a commit
to dsavitsky-dsr/connectedhomeip
that referenced
this pull request
Jul 9, 2025
* increasing UT coverage for src/lib/address_resolve. * fix for OnOperationalNode[Resolved|ResolutionFailed] test. Restyled by clang-format * Test covering Resolver::ShutDown added. * unused thread & iostream headers removed. * fix for typos in TEST name. * restoring real clock before ending tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
Increased unit tests coverage for #37237
Tests added for
src/lib/address_resolve