8000 Added new source files for the commodity metering cluster server by dsavitsky-dsr · Pull Request #39688 · project-chip/connectedhomeip · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added new source files for the commodity metering cluster server #39688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 46 commits into
base: master
Choose a base branch
from
Open

Added new source files for the commodity metering cluster server #39688

wants to merge 46 commits into from
+809 −313

Conversation

dsavitsky-dsr
Copy link
Contributor
@dsavitsky-dsr dsavitsky-dsr commented Jun 24, 2025 •
edited
Loading

Summary

This PR includes source files necessary to implement the server side of commodity metering cluster

Testing

@github-actions github-actions bot added the app label Jun 24, 2025
@gemini-code-assist Gemini Code Assist
Copy link
Contributor

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

@github-actions GitHub Actions
Copy link
github-actions bot commented Jun 24, 2025 •
edited
Loading

PR #39688: Size comparison from fc8791b to 7c30ae4

Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen) 8000
platform target config section fc8791b 7c30ae4 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1103294 1103294 0 0.0
RAM 179026 179026 0 0.0
bl702 lighting-app bl702+eth FLASH 656460 656460 0 0.0
RAM 134969 134969 0 0.0
bl702+wifi FLASH 833886 833886 00.0
RAM 124541 124541 0 0.0
bl706+mfd+rpc+littlefs FLASH 1066306 1066306 0 0.0
RAM 117373 117373 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 895870 895870 0 0.0
RAM 105660 105660 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 979588 979588 0 0.0
RAM 109860 109860 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 764112 764112 0 0.0
RAM 103352 103352 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 775772 775772 0 0.0
RAM 108520 108520 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 721888 721888 0 0.0
RAM 96924 96924 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 706188 706188 0 0.0
RAM 97124 97124 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 549454 549454 0 0.0
RAM 205144 205144 0 0.0
lock CC3235SF_LAUNCHXL FLASH 582574 582574 0 0.0
RAM 205344 205344 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 663541 663541 0 0.0
RAM 77456 77456 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 683393 683393 0 0.0
RAM 80096 80096 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 683393 683393 0 0.0
RAM 80096 80096 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 640325 640325 0 0.0
RAM 72524 72524 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 624917 624917 0 0.0
RAM 73776 73776 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 644553 644553 0 0.0
RAM 76328 76328 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 644553 644553 0 0.0
RAM 76328 76328 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 645861 645861 0 0.0
RAM 76776 76776 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 665569 665569 0 0.0
RAM 79328 79328 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 665569 665569 0 0.0
RAM 79328 79328 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 620529 620529 0 0.0
RAM 70880 70880 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 640381 640381 0 0.0
RAM 73512 73512 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 640381 640381 0 0.0
RAM 73512 73512 0 0.0
efr32 lock-app BRD4187C FLASH 948380 948380 0 0.0
RAM 132004 132004 0 0.0
BRD4338a FLASH 745388 745380 -8 -0.0
RAM 206892 206892 0 0.0
window-app BRD4187C FLASH 1041616 1041608 -8 -0.0
RAM 128132 128132 0 0.0
esp32 all-clusters-app c3devkit DRAM 103496 103496 0 0.0
FLASH 1811262 1811262 0 0.0
IRAM 83862 83862 0 0.0
m5stack DRAM 122356 122356 0 0.0
FLASH 1776306 1776306 0 0.0
IRAM 117071 117071 0 0.0
linux air-purifier-app debug unknown 4848 4848 0 0.0
FLASH 2797452 2797452 0 0.0
RAM 117320 117320 0 0.0
all-clusters-app debug unknown 5664 5664 0 0.0
FLASH 6385976 6385976 0 0.0
RAM 538336 538336 0 0.0
all-clusters-minimal-app debug unknown 5528 5528 0 0.0
FLASH 5475770 5475770 0 0.0
RAM 228024 228024 0 0.0
bridge-app debug unknown 5560 5560 0 0.0
FLASH 4808102 4808102 0 0.0
RAM 207712 207712 0 0.0
camera-app debug unknown 8968 8968 0 0.0
FLASH 6934603 6934603 0 0.0
RAM 229832 229832 0 0.0
camera-controller debug unknown 9184 9184 0 0.0
FLASH 14331979 14331979 0 0.0
RAM 659544 659544 0 0.0
chip-tool debug unknown 6240 6240 0 0.0
FLASH 14674233 14674233 0 0.0
RAM 653064 653064 0 0.0
chip-tool-ipv6only arm64 unknown 40544 40544 0 0.0
FLASH 12655455 12655455 0 0.0
RAM 699352 699352 0 0.0
fabric-admin debug unknown 5920 5920 0 0.0
FLASH 12742137 12742137 0 0.0
RAM 652088 652088 0 0.0
fabric-bridge-app debug unknown 4808 4808 0 0.0
FLASH 4594332 4594332 0 0.0
RAM 193472 193472 0 0.0
fabric-sync debug unknown 5056 5056 0 0.0
FLASH 5742717 5742717 0 0.0
RAM 490896 490896 0 0.0
lighting-app debug+rpc+ui unknown 6272 6272 0 0.0
FLASH 5656977 5656977 0 0.0
RAM 209864 209864 0 0.0
lock-app debug unknown 5488 5488 0 0.0
FLASH 4838266 4838266 0 0.0
RAM 197096 197096 0 0.0
ota-provider-app debug unknown 4848 4848 0 0.0
FLASH 4447000 4447000 0 0.0
RAM 186160 186160 0 0.0
ota-requestor-app debug unknown 4728 4728 0 0.0
FLASH 4519158 4519158 0 0.0
RAM 188968 188968 0 0.0
shell debug unknown 4248 4248 0 0.0
FLASH 3085932 3085932 0 0.0
RAM 151624 151624 0 0.0
thermostat-no-ble arm64 unknown 9800 9800 0 0.0
FLASH 4235847 4235847 0 0.0
RAM 233336 233336 0 0.0
tv-app debug unknown 5824 5824 0 0.0
FLASH 6106957 6106957 0 0.0
RAM 615128 615128 0 0.0
tv-casting-app debug unknown 5336 5336 0 0.0
FLASH 12824237 12824237 0 0.0
RAM 769232 769232 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 916232 916232 0 0.0
RAM 167438 167438 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 914180 914180 0 0.0
RAM 145660 145660 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 859728 859728 0 0.0
RAM 141045 141045 0 0.0
nxp contact mcxw71+release FLASH 625808 625808 0 0.0
RAM 63140 63140 8000 0 0.0
lock mcxw71+release FLASH 777056 777056 0 0.0
RAM 67804 67804 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1673788 1673788 0 0.0
RAM 212416 212416 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1576996 1576996 0 0.0
RAM 208464 208464 0 0.0
light cy8ckit_062s2_43012 FLASH 1449612 1449612 0 0.0
RAM 197184 197184 0 0.0
lock cy8ckit_062s2_43012 FLASH 1481980 1481980 0 0.0
RAM 224904 224904 0 0.0
qpg lighting-app qpg6200+debug FLASH 741080 741080 0 0.0
RAM 94088 94088 0 0.0
lock-app qpg6200+debug FLASH 751268 751268 0 0.0
RAM 94116 94116 0 0.0
stm32 light STM32WB5MM-DK FLASH 466244 466244 0 0.0
RAM 141376 141376 0 0.0
telink bridge-app tl7218x FLASH 705226 705226 0 0.0
RAM 93636 93636 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 796854 796854 0 0.0
RAM 44052 44052 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 785256 785256 0 0.0
RAM 100948 100948 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 712564 712564 0 0.0
RAM 54276 54276 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 749140 749140 0 0.0
RAM 77440 77440 0 0.0
light-switch-app-ota-factory-data tl3218x_retention FLASH 725884 725884 0 0.0
RAM 37032 37032 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 605426 605426 0 0.0
RAM 112428 112428 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 820836 820840 4 0.0
RAM 99200 99200 0 0.0
tizen all-clusters-app arm unknown 5312 5312 0 0.0
FLASH 1821120 1821120 0 0.0
RAM 97516 97516 0 0.0
chip-tool-ubsan arm unknown 20700 20700 0 0.0
FLASH 20969098 20969098 0 0.0
RAM 9122928 9122928 0 0.0

@dsavitsky-dsr dsavitsky-dsr force-pushed the commodity_metering_server branch from 7c30ae4 to acae1bf Compare June 25, 2025 16:09
@github-actions GitHub Actions
Copy link

PR #39688: Size comparison from 230883d to acae1bf

Full report (1 build for stm32)
platform target config section 230883d acae1bf change % change
stm32 light STM32WB5MM-DK FLASH 466236 466236 0 0.0
RAM 141376 141376 0 0.0

bzbarsky-apple
bzbarsky-apple requested changes Jun 26, 2025
View reviewed changes
@dsavitsky-dsr
Copy link
Contributor Author

/gemini review

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jun 26, 2025
View reviewed changes
Copy link
Contributor
@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR introduces the source files for the commodity metering cluster server. The changes include defining the cluster in .matter and .zap files, implementing the server logic in C++, and adding necessary build configurations. The review focuses on documentation accuracy, code clarity, and verifying the correctness of storage option changes.

@github-actions GitHub Actions
Copy link
github-actions bot commented Jun 26, 2025 •
edited
8000 Loading

PR #39688: Size comparison from 230883d to af7daea

Increases above 0.2%:

platform target config section 230883d af7daea change % change
qpg lighting-app qpg6200+debug FLASH 741080 744784 3704 0.5
lock-app qpg6200+debug FLASH 751268 754540 3272 0.4
Full report (12 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32)
platform target config section 230883d af7daea change % change
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 764096 764056 -40 -0.0
RAM 103352 103360 8 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 775764 775764 0 0.0
RAM 108520 108536 16 0.0
pump-app LP_EM_CC1354P10_6 FLASH 721872 721856 -16 -0.0
RAM 96924 96940 16 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 706172 706156 -16 -0.0
RAM 97124 97140 16 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 549446 549446 0 0.0
RAM 205144 205144 0 0.0
lock CC3235SF_LAUNCHXL FLASH 582566 582566 0 0.0
RAM 205344 205344 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 916228 916212 -16 -0.0
RAM 167438 167442 4 0.0
nrf7002dk_nrf5340_cpuapp FLASH 914168 914168 0 0.0
RAM 145660 145660 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 859716 859704 -12 -0.0
RAM 141045 141049 4 0.0
qpg lighting-app qpg6200+debug FLASH 741080 744784 3704 0.5
RAM 94088 94212 124 0.1
lock-app qpg6200+debug FLASH 751268 754540 3272 0.4
RAM 94116 94248 132 0.1
stm32 light STM32WB5MM-DK FLASH 466236 466228 -8 -0.0
RAM 141376 141368 -8 -0.0

@mergify mergify bot added the conflict label Jun 28, 2025
@mergify mergify bot removed the conflict label Jun 30, 2025
@github-actions GitHub Actions
Copy link

PR #39688: Size comparison from 89257e3 to e1f2fb2

Full report (1 build for stm32)
platform target config section 89257e3 e1f2fb2 change % change
stm32 light STM32WB5MM-DK FLASH 466252 466252 0 0.0
RAM 141376 141376 0 0.0

@github-actions GitHub Actions
Copy link
github-actions bot commented Jun 30, 2025 •
edited
Loading

PR #39688: Size comparison from 89257e3 to b54be9f

Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 89257e3 b54be9f change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1103302 1103302 0 0.0
RAM 179026 179026 0 0.0
bl702 lighting-app bl702+eth FLASH 656454 656454 0 0.0
RAM 134977 134977 0 0.0
bl702+wifi FLASH 833892 833892 0 0.0
RAM 124541 124541 0 0.0
bl706+mfd+rpc+littlefs FLASH 1066262 1066262 0 0.0
RAM 117397 117397 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 895808 895808 0 0.0
RAM 105676 105676 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 979526 979526 0 0.0
RAM 109876 109876 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 764080 764080 0 0.0
RAM 103368 103368 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 775772 775772 0 0.0
RAM 108536 108536 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 721880 721880 0 0.0
RAM 96940 96940 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 706180 706180 0 0.0
RAM 97148 97148 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 549470 549470 0 0.0
RAM 205144 205144 0 0.0
lock CC3235SF_LAUNCHXL FLASH 582590 582590 0 0.0
RAM 205344 205344 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 663541 663541 0 0.0
RAM 77472 77472 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 683385 683385 0 0.0
RAM 80112 80112 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 683385 683385 0 0.0
RAM 80112 80112 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 640325 640325 0 0.0
RAM 72540 72540 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 624917 624917 0 0.0
RAM 73784 73784 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 644545 644545 0 0.0
RAM 76336 76336 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 644545 644545 0 0.0
RAM 76336 76336 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 645853 645853 0 0.0
RAM 76784 76784 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 665561 665561 0 0.0
RAM 79336 79336 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 665561 665561 0 0.0
RAM 79336 79336 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 620529 620529 0 0.0
RAM 70888 70888 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 640381 640381 0 0.0
RAM 73520 73520 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 640381 640381 0 0.0
RAM 73520 73520 0 0.0
efr32 lock-app BRD4187C FLASH 948164 948164 0 0.0
RAM 131528 131528 0 0.0
BRD4338a FLASH 745484 745476 -8 -0.0
RAM 206896 206896 0 0.0
window-app BRD4187C FLASH 1041520 1041512 -8 -0.0
RAM 127656 127656 0 0.0
esp32 all-clusters-app c3devkit DRAM 102272 102272 0 0.0
FLASH 1781472 1781472 0 0.0
IRAM 83862 83862 0 0.0
m5stack DRAM 121156 121156 0 0.0
FLASH 1748702 1748706 4 0.0
IRAM 117071 117071 0 0.0
linux air-purifier-app debug unknown 4848 4848 0 0.0
FLASH 2798086 2798086 0 0.0
RAM 117384 117384 0 0.0
all-clusters-app debug unknown 5664 5664 0 0.0
FLASH 6201300 6201300 0 0.0
RAM 530400 530400 0 0.0
all-clusters-minimal-app debug unknown 5528 5528 0 0.0
FLASH 5475456 5475456 0 0.0
RAM 228088 228088 0 0.0
bridge-app debug unknown 5560 5560 0 0.0
FLASH 4808736 4808736 0 0.0
RAM 207776 207776 0 0.0
camera-app debug unknown 8968 8968 0 0.0
FLASH 6935003 6935003 0 0.0
RAM 230088 230088 0 0.0
camera-controller debug unknown 9184 9184 0 0.0
FLASH 14321691 14321691 0 0.0
RAM 658968 658968 0 0.0
chip-tool debug unknown 6240 6240 0 0.0
FLASH 14660051 14660051 0 0.0
RAM 652520 652520 0 0.0
chip-tool-ipv6only arm64 unknown 40528 40528 0 0.0
FLASH 12645279 12645279 0 0.0
RAM 698784 698784 0 0.0
fabric-admin debug unknown 5920 5920 0 0.0
FLASH 12732767 12732767 0 0.0
RAM 651512 651512 0 0.0
fabric-bridge-app debug unknown 4808 4808 0 0.0
FLASH 4594998 4594998 0 0.0
RAM 193536 193536 0 0.0
fabric-sync debug unknown 5056 5056 0 0.0
FLASH 5744029 5744029 0 0.0
RAM 490864 490864 0 0.0
lighting-app debug+rpc+ui unknown 6272 6272 0 0.0
FLASH 5657649 5657649 0 0.0
RAM 209928 209928 0 0.0
lock-app debug unknown 5488 5488 0 0.0
FLASH 4838930 4838930 0 0.0
RAM 197160 197160 0 0.0
ota-provider-app debug unknown 4848 4848 0 0.0
FLASH 4447664 4447664 0 0.0
RAM 186224 186224 0 0.0
ota-requestor-app debug unknown 4728 4728 0 0.0
FLASH 4519822 4519822 0 0.0
RAM 189064 189064 0 0.0
shell debug unknown 4248 4248 0 0.0
FLASH 3080748 3080748 0 0.0
RAM 147328 147328 0 0.0
thermostat-no-ble arm64 unknown 9800 9800 0 0.0
FLASH 4236247 4236247 0 0.0
RAM 233392 233392 0 0.0
tv-app debug unknown 5824 5824 0 0.0
FLASH 6108269 6108269 0 0.0
RAM 615096 615096 0 0.0
tv-casting-app debug unknown 5336 5336 0 0.0
FLASH 12809805 12809805 0 0.0
RAM 768608 768608 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 889212 889212 0 0.0
RAM 166162 166162 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 897256 897256 0 0.0
RAM 145100 145100 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 859740 859740 0 0.0
RAM 141049 141049 0 0.0
nxp contact mcxw71+release FLASH 625824 625824 0 0.0
RAM 63164 63164 0 0.0
lock mcxw71+release FLASH 777056 777056 0 0.0
RAM 67820 67820 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1632916 1632916 0 0.0
RAM 211104 211104 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1577108 1577108 0 0.0
RAM 208472 208472 0 0.0
light cy8ckit_062s2_43012 FLASH 1449708 1449708 0 0.0
RAM 197184 197184 0 0.0
lock cy8ckit_062s2_43012 FLASH 1482076 1482076 0 0.0
RAM 224904 224904 0 0.0
qpg lighting-app qpg6200+debug FLASH 744800 744800 0 0.0
RAM 94220 94220 0 0.0
lock-app qpg6200+debug FLASH 754572 754572 0 0.0
RAM 94248 94248 0 0.0
stm32 light STM32WB5MM-DK FLASH 466252 466252 0 0.0
RAM 141376 141376 0 0.0
telink bridge-app tl7218x FLASH 703352 703352 0 0.0
RAM 93600 93600 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 795066 795066 0 0.0
RAM 44016 44016 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 783472 783472 0 0.0
RAM 100912 100912 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 710778 710778 0 0.0
RAM 54240 54240 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 747352 747352 0 0.0
RAM 77404 77404 0 0.0
light-switch-app-ota-factory-data tl3218x_retention FLASH 724098 724098 0 0.0
RAM 36996 36996 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 603650 603650 0 0.0
RAM 112532 112532 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 819046 819050 4 0.0
RAM 99164 99164 0 0.0
tizen all-clusters-app arm unknown 5128 5128 0 0.0
FLASH 1698240 1698240 0 0.0
RAM 91464 91464 0 0.0
chip-tool-ubsan arm unknown 20692 20692 0 0.0
FLASH 20943266 20943266 0 0.0
RAM 9111456 9111456 0 0.0

bzbarsky-apple
bzbarsky-apple reviewed Jul 1, 2025
View reviewed changes
src/app/clusters/commodity-metering-server/commodity-metering-server.cpp
template <typename T>
struct SpanCopier
{
static bool Copy(const chip::Span<const T> & source, DataModel::List<const T> & destination,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
static bool Copy(const chip::Span<const T> & source, DataModel::List<const T> & destination,
static bool Copy(const Span<const T> & source, DataModel::List<const T> & destination,

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why has this been marked as resolved? Change hasn't been applied?

dsavitsky-dsr and others added 5 commits July 1, 2025 11:28
@dsavitsky-dsr @bzbarsky-apple
Update src/app/clusters/commodity-metering-server/commodity-metering-…
ba2b2e8 
…server.cpp

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
@dsavitsky-dsr @bzbarsky-apple
Update src/app/clusters/commodity-metering-server/commodity-metering-…
a9beada 
…server.cpp

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
@dsavitsky-dsr @bzbarsky-apple
Update src/app/clusters/commodity-metering-server/commodity-metering-…
396a44d 
…server.cpp

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
@dsavitsky-dsr @bzbarsky-apple
Update src/app/clusters/commodity-metering-server/commodity-metering-…
8be028a 
…server.cpp

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
@dsavitsky-dsr @bzbarsky-apple
Update src/app/clusters/commodity-metering-server/commodity-metering-…
7557a9b 
…server.cpp

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
@dsavitsky-dsr dsavitsky-dsr requested a review from jamesharrow July 9, 2025 12:01
dsavitsky-dsr and others added 3 commits July 9, 2025 15:02
@bzbarsky-apple
Copy link
Contributor

/gemini review

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jul 10, 2025
View reviewed changes
Copy link
Contributor
@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the server-side implementation for the Commodity Metering cluster. The review identified a critical correctness issue: there is a discrepancy between the cluster attribute defined in the .matter file (tariffUnit) and the attribute implemented in the C++ source files (measurementType). This affects the header, implementation, and ZCL JSON configuration files.

bzbarsky-apple
bzbarsky-apple reviewed Jul 10, 2025
View reviewed changes
@mergify mergify bot added the conflict label Jul 11, 2025
@mergify mergify bot removed the conflict label Jul 11, 2025
dsavitsky-dsr and others added 3 commits July 11, 2025 06:54
@dsavitsky-dsr @bzbarsky-apple
Update src/app/clusters/commodity-metering-server/commodity-metering-…
2a47b36 
…server.cpp

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
@dsavitsky-dsr @bzbarsky-apple
Update src/app/clusters/commodity-metering-server/commodity-metering-…
8387108 
…server.cpp

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
@dsavitsky-dsr @bzbarsky-apple
Update src/app/clusters/commodity-metering-server/commodity-metering-…
7f59d06 
…server.cpp

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
@github-actions GitHub Actions
Copy link
github-actions bot commented Jul 11, 2025 •
edited
Loading

PR #39688: Size comparison from 00aa48e to 7f59d06

Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 00aa48e 7f59d06 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1102594 1102594 0 0.0
RAM 179010 179010 0 0.0
bl702 lighting-app bl702+eth FLASH 656002 656002 0 0.0
RAM 134961 134961 0 0.0
bl702+wifi FLASH 833184 833184 0 0.0
RAM 124517 124517 0 0.0
bl706+mfd+rpc+littlefs FLASH 1065302 1065302 0 0.0
RAM 117373 117373 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 894848 894848 0 0.0
RAM 105660 105660 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 978566 978566 0 0.0
RAM 109852 109852 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 763096 763096 0 0.0
RAM 103368 103368 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 774636 774636 0 0.0
RAM 108536 108536 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 720976 720976 0 0.0
RAM 96940 96940 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 705268 705268 0 0.0
RAM 97148 97148 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 548818 548818 0 0.0
RAM 205144 205144 0 0.0
lock CC3235SF_LAUNCHXL FLASH 581810 581810 0 0.0
RAM 205344 205344 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 662581 662581 0 0.0
RAM 77472 77472 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 682433 682433 0 0.0
RAM 80112 80112 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 682433 682433 0 0.0
RAM 80112 80112 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 639365 639365 0 0.0
RAM 72540 72540 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 623805 623805 0 0.0
RAM 73784 73784 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 643441 643441 0 0.0
RAM 76336 76336 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 643441 643441 0 0.0
RAM 76336 76336 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 644765 644765 0 0.0
RAM 76784 76784 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 664481 664481 0 0.0
RAM 79336 79336 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 664481 664481 0 0.0
RAM 79336 79336 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 619545 619545 0 0.0
RAM 70888 70888 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 639397 639397 0 0.0
RAM 73520 73520 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 639397 639397 0 0.0
RAM 73520 73520 0 0.0
efr32 lock-app BRD4187C FLASH 954984 954984 0 0.0
RAM 126564 126564 0 0.0
BRD4338a FLASH 749404 749396 -8 -0.0
RAM 251912 251912 0 0.0
window-app BRD4187C FLASH 1049512 1049512 0 0.0
RAM 122760 122760 0 0.0
esp32 all-clusters-app c3devkit DRAM 102272 102272 0 0.0
FLASH 1780200 1780200 0 0.0
IRAM 83862 83862 0 0.0
m5stack DRAM 121156 121156 0 0.0
FLASH 1747498 1747498 0 0.0
IRAM 117071 117071 0 0.0
linux air-purifier-app debug unknown 4856 4856 0 0.0
FLASH 2796542 2796542 0 0.0
RAM 117320 117320 0 0.0
all-clusters-app debug unknown 5672 5672 0 0.0
FLASH 6197262 6197262 0 0.0
RAM 531216 531216 0 0.0
all-clusters-minimal-app debug unknown 5536 5536 0 0.0
FLASH 5473452 5473452 0 0.0
RAM 228008 228008 0 0.0
bridge-app debug unknown 5568 5568 0 0.0
FLASH 4807692 4807692 0 0.0
RAM 207712 207712 0 0.0
camera-app debug unknown 8976 8976 0 0.0
FLASH 6933259 6934139 880 0.0
RAM 230024 230024 0 0.0
camera-controller debug unknown 9216 9216 0 0.0
FLASH 14387099 14387099 0 0.0
RAM 661528 661528 0 0.0
chip-tool debug unknown 6272 6272 0 0.0
FLASH 14738075 14738075 0 0.0
RAM 655072 655072 0 0.0
chip-tool-ipv6only arm64 unknown 40672 40672 0 0.0
FLASH 12713215 12713215 0 0.0
RAM 701344 701344 0 0.0
closure-app debug unknown 5536 5536 0 0.0
FLASH 4791244 4791244 0 0.0
RAM 200616 200616 0 0.0
fabric-admin debug unknown 5952 5952 0 0.0
FLASH 12798571 12798571 0 0.0
RAM 654104 654104 0 0.0
fabric-bridge-app debug unknown 4816 4816 0 0.0
FLASH 4593024 4593024 0 0.0
RAM 193424 193424 0 0.0
fabric-sync debug unknown 5056 5056 0 0.0
FLASH 5741549 5741549 0 0.0
RAM 491728 491728 0 0.0
lighting-app debug+rpc+ui unknown 6280 6280 0 0.0
FLASH 5694481 5694481 0 0.0
RAM 209944 209944 0 0.0
lock-app debug unknown 5488 5488 0 0.0
FLASH 4836372 4836372 0 0.0
RAM 197192 197192 0 0.0
ota-provider-app debug unknown 4856 4856 0 0.0
FLASH 4446878 4446878 0 0.0
RAM 186112 186112 0 0.0
ota-requestor-app debug unknown 4736 4736 0 0.0
FLASH 4519002 4519002 0 0.0
RAM 188984 188984 0 0.0
shell debug unknown 4288 4288 0 0.0
FLASH 3076460 3076460 0 0.0
RAM 147344 147344 0 0.0
thermostat-no-ble arm64 unknown 9832 9832 0 0.0
FLASH 4236159 4236159 0 0.0
RAM 233304 233304 0 0.0
tv-app debug unknown 5824 5824 0 0.0
FLASH 6106541 6106541 0 0.0
RAM 615976 615976 0 0.0
tv-casting-app debug unknown 5352 5352 0 0.0
FLASH 12887773 12887773 0 0.0
RAM 771728 771728 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 888068 888068 0 0.0
RAM 166162 166162 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 897144 897144 0 0.0
RAM 145100 145100 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 858392 858392 0 0.0
RAM 141049 141049 0 0.0
nxp contact mcxw71+release FLASH 624768 624768 0 0.0
RAM 63164 63164 0 0.0
lock mcxw71+release FLASH 775976 775976 0 0.0
RAM 67820 67820 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1632484 1632484 0 0.0
RAM 211104 211104 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1576660 1576660 0 0.0
RAM 208472 208472 0 0.0
light cy8ckit_062s2_43012 FLASH 1449452 1449452 0 0.0
RAM 197184 197184 0 0.0
lock cy8ckit_062s2_43012 FLASH 1481708 1481708 0 0.0
RAM 224904 224904 0 0.0
qpg lighting-app qpg6200+debug FLASH 743824 743824 0 0.0
RAM 94220 94220 0 0.0
lock-app qpg6200+debug FLASH 753444 753444 0 0.0
RAM 94248 94248 0 0.0
stm32 light STM32WB5MM-DK FLASH 465260 465260 0 0.0
RAM 141376 141376 0 0.0
telink bridge-app tl7218x FLASH 702312 702312 0 0.0
RAM 93600 93600 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 794044 794044 0 0.0
RAM 44016 44016 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 782450 782450 0 0.0
RAM 100912 100912 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 709564 709564 0 0.0
RAM 54240 54240 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 746158 746158 0 0.0
RAM 77404 77404 0 0.0
light-switch-app-ota-factory-data tl3218x_retention FLASH 722884 722884 0 0.0
RAM 36996 36996 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 602986 602986 0 0.0
RAM 112532 112532 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 818004 818008 4 0.0
RAM 99164 99164 0 0.0
tizen all-clusters-app arm unknown 5096 5096 0 0.0
FLASH 1695744 1695744 0 0.0
RAM 91444 91444 0 0.0
chip-tool-ubsan arm unknown 20764 20764 0 0.0
FLASH 21066570 21066578 8 0.0
RAM 9165480 9165432 -48 -0.0

@dsavitsky-dsr
Copy link
Contributor Author

/gemini review

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jul 11, 2025
View reviewed changes
Copy link
Contributor
@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the server-side implementation for the Commodity Metering cluster, including source files, build configurations, and cluster definitions. The implementation uses C++ with an AttributeAccessInterface for custom attribute handling. A potential issue regarding state consistency when setting MeteredQuantity has been identified.

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jul 11, 2025
View reviewed changes
Copy link
Contributor
@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the server-side implementation for the Commodity Metering cluster. The changes include adding the cluster definition, C++ implementation files for the server logic, and necessary build file updates. The new code is well-structured and follows the existing patterns for cluster implementation in the project. I have one suggestion to improve code conciseness by using an STL algorithm.

@github-actions GitHub Actions
Copy link

PR #39688: Size comparison from 00aa48e to 4a4eaa8

Full report (1 build for stm32)
platform target config section 00aa48e 4a4eaa8f change % change
stm32 light STM32WB5MM-DK FLASH 465260 465260 0 0.0
RAM 141376 141376 0 0.0

dsavitsky-dsr
dsavitsky-dsr commented Jul 11, 2025
View reviewed changes
Copy link
Contributor Author
@dsavitsky-dsr dsavitsky-dsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All necessary corrections have been made.

@github-actions GitHub Actions
Copy link
github-actions bot commented Jul 11, 2025 •
edited
Loading

PR #39688: Size comparison from 00aa48e to eb60713

Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 00aa48e eb60713 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1102594 1102594 0 0.0
RAM 179010 179010 0 0.0
bl702 lighting-app bl702+eth FLASH 656002 656002 0 0.0
RAM 134961 134961 0 0.0
bl702+wifi FLASH 833184 833184 0 0.0
RAM 124517 124517 0 0.0
bl706+mfd+rpc+littlefs FLASH 1065302 1065302 0 0.0
RAM 117373 117373 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 894848 894848 0 0.0
RAM 105660 105660 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 978566 978566 0 0.0
RAM 109852 109852 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 763096 763096 0 0.0
RAM 103368 103368 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 774636 774636 0 0.0
RAM 108536 108536 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 720976 720976 0 0.0
RAM 96940 96940 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 705268 705268 0 0.0
RAM 97148 97148 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 548818 548818 0 0.0
RAM 205144 205144 0 0.0
lock CC3235SF_LAUNCHXL FLASH 581810 581810 0 0.0
RAM 205344 205344 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 662581 662581 0 0.0
RAM 77472 77472 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 682433 682433 0 0.0
RAM 80112 80112 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 682433 682433 0 0.0
RAM 80112 80112 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 639365 639365 0 0.0
RAM 72540 72540 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 623805 623805 0 0.0
RAM 73784 73784 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 643441 643441 0 0.0
RAM 76336 76336 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 643441 643441 0 0.0
RAM 76336 76336 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 644765 644765 0 0.0
RAM 76784 76784 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 664481 664481 0 0.0
RAM 79336 79336 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 664481 664481 0 0.0
RAM 79336 79336 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 619545 619545 0 0.0
RAM 70888 70888 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 639397 639397 0 0.0
RAM 73520 73520 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 639397 639397 0 0.0
RAM 73520 73520 0 0.0
efr32 lock-app BRD4187C FLASH 954984 954984 0 0.0
RAM 126564 126564 0 0.0
BRD4338a FLASH 749404 749396 -8 -0.0
RAM 251912 251912 0 0.0
window-app BRD4187C FLASH 1049512 1049512 0 0.0
RAM 122760 122760 0 0.0
esp32 all-clusters-app c3devkit DRAM 102272 102272 0 0.0
FLASH 1780200 1780588 388 0.0
IRAM 83862 83862 0 0.0
m5stack DRAM 121156 121156 0 0.0
FLASH 1747498 1747854 356 0.0
IRAM 117071 117071 0 0.0
linux air-purifier-app debug unknown 4856 4856 0 0.0
FLASH 2796542 2796542 0 0.0
RAM 117320 117320 0 0.0
all-clusters-app debug unknown 5672 5672 0 0.0
FLASH 6197262 6198100 838 0.0
RAM 531216 531216 0 0.0
all-clusters-minimal-app debug unknown 5536 5536 0 0.0
FLASH 5473452 5473452 0 0.0
RAM 228008 228008 0 0.0
bridge-app debug unknown 5568 5568 0 0.0
FLASH 4807692 4807692 0 0.0
RAM 207712 207712 0 0.0
camera-app debug unknown 8976 8976 0 0.0
FLASH 6933259 6935019 1760 0.0
RAM 230024 230024 0 0.0
camera-controller debug unknown 9216 9216 0 0.0
FLASH 14387099 14387099 0 0.0
RAM 661528 661528 0 0.0
chip-tool debug unknown 6272 6272 0 0.0
FLASH 14738075 14738075 0 0.0
RAM 655072 655072 0 0.0
chip-tool-ipv6only arm64 unknown 40672 40672 0 0.0
FLASH 12713215 12713215 0 0.0
RAM 701344 701344 0 0.0
closure-app debug unknown 5536 5536 0 0.0
FLASH 4791244 4791244 0 0.0
RAM 200616 200616 0 0.0
fabric-admin debug unknown 5952 5952 0 0.0
FLASH 12798571 12798571 0 0.0
RAM 654104 654104 0 0.0
fabric-bridge-app debug unknown 4816 4816 0 0.0
FLASH 4593024 4593024 0 0.0
RAM 193424 193424 0 0.0
fabric-sync debug unknown 5056 5056 0 0.0
FLASH 5741549 5741549 0 0.0
RAM 491728 491728 0 0.0
lighting-app debug+rpc+ui unknown 6280 6280 0 0.0
FLASH 5694481 5694481 0 0.0
RAM 209944 209944 0 0.0
lock-app debug unknown 5488 5488 0 0.0
FLASH 4836372 4836372 0 0.0
RAM 197192 197192 0 0.0
ota-provider-app debug unknown 4856 4856 0 0.0
FLASH 4446878 4446878 0 0.0
RAM 186112 186112 0 0.0
ota-requestor-app debug unknown 4736 4736 0 0.0
FLASH 4519002 4519002 0 0.0
RAM 188984 188984 0 0.0
shell debug unknown 4288 4288 0 0.0
FLASH 3076460 3076460 0 0.0
RAM 147344 147344 0 0.0
thermostat-no-ble arm64 unknown 9832 9832 0 0.0
FLASH 4236159 4236159 0 0.0
RAM 233304 233304 0 0.0
tv-app debug unknown 5824 5824 0 0.0
FLASH 6106541 6106541 0 0.0
RAM 615976 615976 0 0.0
tv-casting-app debug unknown 5352 5352 0 0.0
FLASH 12887773 12887773 0 0.0
RAM 771728 771728 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 888068 888068 0 0.0
RAM 166162 166162 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 897144 897144 0 0.0
RAM 145100 145100 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 858392 858392 0 0.0
RAM 141049 141049 0 0.0
nxp contact mcxw71+release FLASH 624768 624768 0 0.0
RAM 63164 63164 0 0.0
lock mcxw71+release FLASH 775976 775976 0 0.0
RAM 67820 67820 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1632484 1632484 0 0.0
RAM 211104 211104 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1576660 1576660 0 0.0
RAM 208472 208472 0 0.0
light cy8ckit_062s2_43012 FLASH 1449452 1449452 0 0.0
RAM 197184 197184 0 0.0
lock cy8ckit_062s2_43012 FLASH 1481708 1481708 0 0.0
RAM 224904 224904 0 0.0
qpg lighting-app qpg6200+debug FLASH 743824 743824 0 0.0
RAM 94220 94220 0 0.0
lock-app qpg6200+debug FLASH 753444 753444 0 0.0
RAM 94248 94248 0 0.0
stm32 light STM32WB5MM-DK FLASH 465260 465260 0 0.0
RAM 141376 141376 0 0.0
telink bridge-app tl7218x FLASH 702312 702312 0 0.0
RAM 93600 93600 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 794044 794044 0 0.0
RAM 44016 44016 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 782450 782450 0 0.0
RAM 100912 100912 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 7 B3E2 09564 709564 0 0.0
RAM 54240 54240 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 746158 746158 0 0.0
RAM 77404 77404 0 0.0
light-switch-app-ota-factory-data tl3218x_retention FLASH 722884 722884 0 0.0
RAM 36996 36996 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 602986 602986 0 0.0
RAM 112532 112532 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 818004 818008 4 0.0
RAM 99164 99164 0 0.0
tizen all-clusters-app arm unknown 5096 5096 0 0.0
FLASH 1695744 1695744 0 0.0
RAM 91444 91444 0 0.0
chip-tool-ubsan arm unknown 20764 20764 0 0.0
FLASH 21066570 21066578 8 0.0
RAM 9165480 9165432 -48 -0.0

jamesharrow
jamesharrow approved these changes Jul 11, 2025
View reviewed changes
Copy link
Contributor
@jamesharrow jamesharrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please file an issue to track the issue around change to the MeasurementType / TariffUnitType.

src/app/clusters/commodity-metering-server/commodity-metering-server.cpp
template <typename T>
struct SpanCopier
{
static bool Copy(const chip::Span<const T> & source, DataModel::List<const T> & destination,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why has this been marked as resolved? Change hasn't been applied?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

@jamesharrow jamesharrow jamesharrow approved these changes

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
app examples review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dsavitsky-dsr @bzbarsky-apple @jamesharrow @hasty
0