8000 increased coverage for src/lib/core/TestCHIPKeyIds.cpp. by gd-mauri · Pull Request #39600 · project-chip/connectedhomeip · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

increased coverage for src/lib/core/TestCHIPKeyIds.cpp. #39600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

increased coverage for src/lib/core/TestCHIPKeyIds.cpp. #39600

wants to merge 4 commits into from

Conversation

gd-mauri
Copy link
Contributor
@gd-mauri gd-mauri commented Jun 18, 2025 •
edited
Loading

Testing

Increased unit tests coverage for #37239

Tests added for src/lib/core/CHIPKeyIds.cpp

These changes contribute to reach 89.5% on src/lib/core:
Captura de pantalla 2025-06-23 a la(s) 11 33 37 a  m

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jun 18, 2025
View reviewed changes
Copy link
Contributor
@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request increases test coverage for CHIPKeyIds.cpp. The feedback focuses on enhancing the readability and maintainability of the new tests by suggesting the use of named constants and identifying potential test redundancy.

@gd-mauri gd-mauri force-pushed the increase_unit_test_coverage_for_lib_core branch from dcf25f7 to d6b723c Compare June 18, 2025 17:42
@github-actions GitHub Actions
Copy link
github-actions bot commented Jun 18, 2025 •
edited
Loading

PR #39600: Size comparison from 943f2f5 to d6b723c

Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 943f2f5 d6b723c change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1103062 1103062 0 0.0
RAM 179026 179026 0 0.0
bl702 lighting-app bl702+eth FLASH 656224 656224 0 0.0
RAM 134969 134969 0 0.0
bl702+wifi FLASH 833650 833650 0 0.0
RAM 124541 124541 0 0.0
bl706+mfd+rpc+littlefs FLASH 1066070 1066070 0 0.0
RAM 117373 117373 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 895628 895628 0 0.0
RAM 105660 105660 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 979352 979352 0 0.0
RAM 109860 109860 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 814492 814492 0 0.0
RAM 120024 120024 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 826184 826184 0 0.0
RAM 125176 125176 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 772052 772052 0 0.0
RAM 113580 113580 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 756360 756360 0 0.0
RAM 113788 113788 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 549382 549382 0 0.0
RAM 205144 205144 0 0.0
lock CC3235SF_LAUNCHXL FLASH 582494 582494 0 0.0
RAM 205336 205336 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 663349 663349 0 0.0
RAM 77456 77456 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 683201 683201 0 0.0
RAM 80096 80096 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 683201 683201 0 0.0
RAM 80096 80096 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 640125 640125 0 0.0
RAM 72524 72524 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 624717 624717 0 0.0
RAM 73768 73768 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 644345 644345 0 0.0
RAM 76320 76320 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 644345 644345 0 0.0
RAM 76320 76320 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 645645 645645 0 0.0
RAM 76768 76768 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 665361 665361 0 0.0
RAM 79320 79320 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 665361 665361 0 0.0
RAM 79320 79320 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 620305 620305 0 0.0
RAM 70880 70880 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 640157 640157 0 0.0
RAM 73512 73512 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 640157 640157 0 0.0
RAM 73512 73512 0 0.0
efr32 lock-app BRD4187C FLASH 947868 947868 0 0.0
RAM 132004 132004 0 0.0
BRD4338a FLASH 744780 744780 0 0.0
RAM 206872 206872 0 0.0
window-app BRD4187C FLASH 1040968 1040968 0 0.0
RAM 128100 128100 0 0.0
esp32 all-clusters-app c3devkit DRAM 103496 103496 0 0.0
FLASH 1811094 1811094 0 0.0
IRAM 83862 83862 0 0.0
m5stack DRAM 122356 122356 0 0.0
FLASH 1776142 1776142 0 0.0
IRAM 117071 117071 0 0.0
linux air-purifier-app debug unknown 4848 4848 0 0.0
FLASH 2796698 2796698 0 0.0
RAM 117352 117352 0 0.0
all-clusters-app debug unknown 5664 5664 0 0.0
FLASH 6385044 6385044 0 0.0
RAM 538336 538336 0 0.0
all-clusters-minimal-app debug unknown 5528 5528 0 0.0
FLASH 5474856 5474856 0 0.0
RAM 228024 228024 0 0.0
bridge-app debug unknown 5560 5560 0 0.0
FLASH 4807350 4807350 0 0.0
RAM 207776 207776 0 0.0
camera-app debug unknown 8968 8968 0 0.0
FLASH 6933707 6933707 0 0.0
RAM 229896 229896 0 0.0
camera-controller debug unknown 9184 9184 0 0.0
FLASH 14330267 14330267 0 0.0
RAM 659288 659288 0 0.0
chip-tool debug unknown 6240 6240 0 0.0
FLASH 14671563 14671563 0 0.0
RAM 652848 652848 0 0.0
chip-tool-ipv6only arm64 unknown 40544 40544 0 0.0
FLASH 12653151 12653151 0 0.0
RAM 699144 699144 0 0.0
fabric-admin debug unknown 5920 5920 0 0.0
FLASH 12739499 12739499 0 0.0
RAM 651832 651832 0 0.0
fabric-bridge-app debug unknown 4808 4808 0 0.0
FLASH 4593550 4593550 0 0.0
RAM 193536 193536 0 0.0
fabric-sync debug unknown 5056 5056 0 0.0
FLASH 5741501 5741501 0 0.0
RAM 490944 490944 0 0.0
lighting-app debug+rpc+ui unknown 6272 6272 0 0.0
FLASH 5656433 5656433 0 0.0
RAM 209928 209928 0 0.0
lock-app debug unknown 5488 5488 0 0.0
FLASH 4837550 4837550 0 0.0
RAM 197160 197160 0 0.0
ota-provider-app debug unknown 4848 4848 0 0.0
FLASH 4446282 4446282 0 0.0
RAM 186192 186192 0 0.0
ota-requestor-app debug unknown 4728 4728 0 0.0
FLASH 4518276 4518276 0 0.0
RAM 189000 189000 0 0.0
shell debug unknown 4248 4248 0 0.0
FLASH 3083964 3083964 0 0.0
RAM 151624 151624 0 0.0
thermostat-no-ble arm64 unknown 9800 9800 0 0.0
FLASH 4235111 4235111 0 0.0
RAM 233432 233432 0 0.0
tv-app debug unknown 5824 5824 0 0.0
FLASH 6105757 6105757 0 0.0
RAM 615176 615176 0 0.0
tv-casting-app debug unknown 5336 5336 0 0.0
FLASH 12824525 12824525 0 0.0
RAM 769296 769296 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 923244 923244 0 0.0
RAM 167416 167416 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 914080 914080 0 0.0
RAM 145660 145660 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 859620 859620 0 0.0
RAM 141045 141045 0 0.0
nxp contact mcxw71+release FLASH 625576 625576 0 0.0
RAM 63140 63140 0 0.0
lock mcxw71+release FLASH 776792 776792 0 0.0
RAM 67804 67804 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1673556 1673556 0 0.0
RAM 212416 212416 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1576780 1576780 0 0.0
RAM 208464 208464 0 0.0
light cy8ckit_062s2_43012 FLASH 1449436 1449436 0 0.0
RAM 197184 197184 0 0.0
lock cy8ckit_062s2_43012 FLASH 1481788 1481788 0 0.0
RAM 224904 224904 0 0.0
qpg lighting-app qpg6200+debug FLASH 740864 740864 0 0.0
RAM 93336 93336 0 0.0
lock-app qpg6200+debug FLASH 751004 751004 0 0.0
RAM 93364 93364 0 0.0
stm32 light STM32WB5MM-DK FLASH 466076 466076 0 0.0
RAM 141376 141376 0 0.0
telink bridge-app tl7218x FLASH 705062 705062 0 0.0
RAM 93636 93636 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 796652 796652 0 0.0
RAM 44052 44052 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 785054 785054 0 0.0
RAM 100948 100948 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 712336 712336 0 0.0
RAM 54272 54272 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 748912 748912 0 0.0
RAM 77436 77436 0 0.0
light-switch-app-ota-factory-data tl3218x_retention FLASH 725656 725656 0 0.0
RAM 37028 37028 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 605222 605222 0 0.0
RAM 112428 112428 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 820634 820638 4 0.0
RAM 99200 99200 0 0.0
tizen all-clusters-app arm unknown 5312 5312 0 0.0
FLASH 1820624 1820624 0 0.0
RAM 97516 97516 0 0.0
chip-tool-ubsan arm unknown 20700 20700 0 0.0
FLASH 20964602 20964602 0 0.0
RAM 9120812 9120812 0 0.0

@gd-mauri gd-mauri force-pushed the increase_unit_test_coverage_for_lib_core branch from d6b723c to b0afb44 Compare June 23, 2025 14:17
@github-actions GitHub Actions
Copy link
github-actions bot commented Jun 23, 2025 •
edited
Loading

PR #39600: Size comparison from 852d123 to 1c37da0

Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 852d123 1c37da0 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1103224 1103224 0 0.0
RAM 179026 179026 0 0.0
bl702 lighting-app bl702+eth FLASH 656390 656390 0 0.0
RAM 134969 134969 0 0.0
bl702+wifi FLASH 833816 833816 0 0.0
RAM 124541 124541 0 0.0
bl706+mfd+rpc+littlefs FLASH 1066236 1066236 0 0.0
RAM 117373 117373 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 895800 895800 0 0.0
RAM 105660 105660 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 979518 979518 0 0.0
RAM 109860 109860 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 764056 764056 0 0.0
RAM 103352 103352 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 775724 775724 0 0.0
RAM 108520 108520 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 721840 721840 0 0.0
RAM 96924 96924 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 706140 706140 0 0.0
RAM 97124 97124 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 549510 549510 0 0.0
RAM 205144 205144 0 0.0
lock CC3235SF_LAUNCHXL FLASH 582630 582630 0 0.0
RAM 205344 205344 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 663501 663501 0 0.0
RAM 77456 77456 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 683345 683345 0 0.0
RAM 80096 80096 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 683345 683345 0 0.0
RAM 80096 80096 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 640285 640285 0 0.0
RAM 72524 72524 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 624869 624869 0 0.0
RAM 73776 73776 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 644505 644505 0 0.0
RAM 76328 76328 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 644505 644505 0 0.0
RAM 76328 76328 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 645821 645821 0 0.0
RAM 76776 76776 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 665537 665537 0 0.0
RAM 79328 79328 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 665537 665537 0 0.0
RAM 79328 79328 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 620489 620489 0 0.0
RAM 70880 70880 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 640341 640341 0 0.0
RAM 73512 73512 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 640341 640341 0 0.0
RAM 73512 73512 0 0.0
efr32 lock-app BRD4187C FLASH 948036 948036 0 0.0
RAM 132004 132004 0 0.0
BRD4338a FLASH 744964 744956 -8 -0.0
RAM 206876 206876 0 0.0
window-app BRD4187C FLASH 1041168 1041160 -8 -0.0
RAM 128132 128132 0 0.0
esp32 all-clusters-app c3devkit DRAM 103496 103496 0 0.0
FLASH 1811286 1811286 0 0.0
IRAM 83862 83862 0 0.0
m5stack DRAM 122356 122356 0 0.0
FLASH 1776306 1776306 0 0.0
IRAM 117071 117071 0 0.0
linux air-purifier-app debug unknown 4848 4848 0 0.0
FLASH 2797082 2797082 0 0.0
RAM 117320 117320 0 0.0
all-clusters-app debug unknown 5664 5664 0 0.0
FLASH 6385606 6385606 0 0.0
RAM 538336 538336 0 0.0
all-clusters-minimal-app debug unknown 5528 5528 0 0.0
FLASH 5475402 5475402 0 0.0
RAM 228024 228024 0 0.0
bridge-app debug unknown 5560 5560 0 0.0
FLASH 4807734 4807734 0 0.0
RAM 207712 207712 0 0.0
camera-app debug unknown 8968 8968 0 0.0
FLASH 6934235 6934235 0 0.0
RAM 229832 229832 0 0.0
camera-controller debug unknown 9184 9184 0 0.0
FLASH 14331611 14331611 0 0.0
RAM 659544 659544 0 0.0
chip-tool debug unknown 6240 6240 0 0.0
FLASH 14673863 14673863 0 0.0
RAM 653064 653064 0 0.0
chip-tool-ipv6only arm64 unknown 40544 40544 0 0.0
FLASH 12654975 12654975 0 0.0
RAM 699352 699352 0 0.0
fabric-admin debug unknown 5920 5920 0 0.0
FLASH 12741737 12741737 0 0.0
RAM 652088 652088 0 0.0
fabric-bridge-app debug unknown 4808 4808 0 0.0
FLASH 4593964 4593964 0 0.0
RAM 193472 193472 0 0.0
fabric-sync debug unknown 5056 5056 0 0.0
FLASH 5742317 5742317 0 0.0
RAM 490896 490896 0 0.0
lighting-app debug+rpc+ui unknown 6272 6272 0 0.0
FLASH 5656609 5656609 0 0.0
RAM 209864 209864 0 0.0
lock-app debug unknown 5488 5488 0 0.0
FLASH 4837898 4837898 0 0.0
RAM 197096 197096 0 0.0
ota-provider-app debug unknown 4848 4848 0 0.0
FLASH 4446632 4446632 0 0.0
RAM 186160 186160 0 0.0
ota-requestor-app debug unknown 4728 4728 0 0.0
FLASH 4518788 4518788 0 0.0
RAM 188968 188968 0 0.0
shell debug unknown 4248 4248 0 0.0
FLASH 3085564 3085564 0 0.0
RAM 151624 151624 0 0.0
thermostat-no-ble arm64 unknown 9800 9800 0 0.0
FLASH 4235367 4235367 0 0.0
RAM 233336 233336 0 0.0
tv-app debug unknown 5824 5824 0 0.0
FLASH 6106589 6106589 0 0.0
RAM 615128 615128 0 0.0
tv-casting-app debug unknown 5336 5336 0 0.0
FLASH 12823869 12823869 0 0.0
RAM 769232 769232 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 923416 923416 0 0.0
RAM 167416 167416 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 914140 914140 0 0.0
RAM 145660 145660 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 859680 859680 0 0.0
RAM 141045 141045 0 0.0
nxp contact mcxw71+release FLASH 625776 625776 0 0.0
RAM 63140 63140 0 0.0
lock mcxw71+release FLASH 776992 776992 0 0.0
RAM 67804 67804 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1673724 1673724 0 0.0
RAM 212416 212416 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1576948 1576948 0 0.0
RAM 208464 208464 0 0.0
light cy8ckit_062s2_43012 FLASH 1449548 1449548 0 0.0
RAM 197184 197184 0 0.0
lock cy8ckit_062s2_43012 FLASH 1481916 1481916 0 0.0
RAM 224904 224904 0 0.0
qpg lighting-app qpg6200+debug FLASH 741032 741032 0 0.0
RAM 94088 94088 0 0.0
lock-app qpg6200+debug FLASH 751220 751220 0 0.0
RAM 94116 94116 0 0.0
stm32 light STM32WB5MM-DK FLASH 466196 466196 0 0.0
RAM 141376 141376 0 0.0
telink bridge-app tl7218x FLASH 705154 705154 0 0.0
RAM 93636 93636 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 796782 796782 0 0.0
RAM 44052 44052 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 785184 785184 0 0.0
RAM 100948 100948 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 712492 712492 0 0.0
RAM 54276 54276 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 749068 749068 0 0.0
RAM 77440 77440 0 0.0
light-switch-app-ota-factory-data tl3218x_retention FLASH 725812 725812 0 0.0
RAM 37032 37032 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 605352 605352 0 0.0
RAM 112428 112428 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 820764 820768 4 0.0
RAM 99200 99200 0 0.0
tizen all-clusters-app arm unknown 5312 5312 0 0.0
FLASH 1821056 1821056 0 0.0
RAM 97516 97516 0 0.0
chip-tool-ubsan arm unknown 20700 20700 0 0.0
FLASH 20968810 20968810 0 0.0
RAM 9122808 9122808 0 0.0

@gd-mauri gd-mauri marked this pull request as ready for review June 24, 2025 12:49
@gd-mauri gd-mauri self-assigned this Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Assignees

@gd-mauri gd-mauri

Labels
core lib review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gd-mauri @restyled-commits
0