Move class MatterTestConfig into its own file matter_test_config.py #39604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Code Review
This pull request moves the MatterTestConfig class into its own file, matter_test_config.py, and updates all references to it across the src/python_testing directory. The changes look good and address the issue of having the class defined in matter_testing.py. There are a few suggestions for minor improvements, such as moving default values to matter_global_defaults.py and adding comments to explain certain default values.
src/python_testing/matter_testing_infrastructure/chip/testing/matter_testing.py
Outdated
Show resolved
Hide resolved
src/python_testing/matter_testing_infrastructure/chip/testing/matter_test_config.py
Show resolved
Hide resolved
|
PR #39604: Size comparison from 943f2f5 to b2893c8 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #39604: Size comparison from 943f2f5 to f26fb21 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
r-recchia
approved these changes
Jun 19, 2025
|
Created issue for |
cecille
approved these changes
Jun 28, 2025
|
PR #39604: Size comparison from 5a3dbea to d0a5d45 Full report (54 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #39604: Size comparison from e0f8e39 to d1a367b Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #39604: Size comparison from d033b40 to 4280ea9 Full report (59 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Proposal to move class MatterTestConfig into is own file.
Move the class
MatterTestConfigfrommatter_testing.pyinto its own file in this casematter_test_config.py.Added new file into build.gn.
Updated references for MatterTestConfig across all
src/python_testingRelated issues
#Fixes project-chip/matter-test-scripts#594
Testing
All Linux REPL test must work.
Pending
There are some
_DEFAULT_<VARIABLENAMES>that are repeated across several files I think we should move those into a file as final variables that can be imported from the files that need them. I think this could be a different improvement for the Python Framework.