[E2E][JF] Add RPC skeleton for ICAC CSR issuance #39740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Code Review
This pull request introduces RPC server streaming functionality to JFA for ICAC CSR issuance. It adds new proto definitions, updates the JointFabric service, and implements the necessary RPC calls in both the JFA and JFC applications. The changes include adding new files, modifying existing ones, and incorporating necessary dependencies. The code introduces new RPC methods for getting and replying with ICAC CSRs, and updates the PairingCommand to use these new RPC methods.
a429065 to
3deb597
Compare
|
PR #39740: Size comparison from 41c7192 to 3deb597 Full report (14 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
3deb597 to
426f8f4
Compare
|
PR #39740: Size comparison from 41c7192 to 426f8f4 Full report (14 builds for cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
46bb22b to
853d1c0
Compare
|
PR #39740: Size comparison from f5239ba to 853d1c0 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
JFA is the RPC server and JFC si the RPC client. JFC is also the PKI Provider so JFA has to call methods on JFC: in order to make this possible this commit is adding RPC Server Streaming functionality on JFA. Signed-off-by: Doru Gucea <doru-cristian.gucea@nxp.com>
853d1c0 to
c566f95
Compare
|
PR #39740: Size comparison from 77d91c0 to c566f95 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
robertfarnum
approved these changes
Jul 2, 2025
vijs
approved these changes
Jul 2, 2025
chrisdecenzo
approved these changes
Jul 3, 2025
robertfarnum
added a commit
to robertfarnum/connectedhomeip
that referenced
this pull request
Jul 7, 2025
dsavitsky-dsr
pushed a commit
to dsavitsky-dsr/connectedhomeip
that referenced
this pull request
Jul 7, 2025
JFA is the RPC server and JFC si the RPC client. JFC is also the PKI Provider so JFA has to call methods on JFC: in order to make this possible this commit is adding RPC Server Streaming functionality on JFA. Signed-off-by: Doru Gucea <doru-cristian.gucea@nxp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
JFA is the RPC server and JFC si the RPC client. JFC is also the PKI Provider
so JFA has to call methods on JFC: in order to make this possible this commit
is adding RPC Server Streaming functionality on JFA.
Fix #39771
Testing
Manual testing for now, integration tests on top of #39637 will be added once all the missing pieces of JCM are implemented.