[EEVSE] Add TC_EEVSE_2_9 [RFID] feature support #39708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Code Review
This pull request adds new test event triggers for setting the State of Charge (SoC), Battery Capacity, Vehicle ID, and triggering RFID events in the Energy EVSE. The changes include modifications to the EnergyEvseDelegateImpl.h and .cpp files to include the new SoC and Battery Capacity attributes, as well as additions to EnergyEvseEventTriggers.cpp and EnergyEvseTestEventTriggerHandler.h to define the new test event triggers and their corresponding handlers. Additionally, TC_EEVSE_Utils.py is updated to include functions for sending these new test event triggers.
|
PR #39708: Size comparison from 2a523d5 to 7a1a4fa Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #39708: Size comparison from e893a32 to a1b9aa6 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
removed line break after merge
removed line break after merge conflicts
|
PR #39708: Size comparison from 6c7a9db to 858adad Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
hasty
approved these changes
Jul 8, 2025
bzbarsky-apple
approved these changes
Jul 8, 2025
...s/energy-management-app/energy-management-common/energy-evse/src/EnergyEvseEventTriggers.cpp
Outdated
Show resolved
Hide resolved
…-evse/src/EnergyEvseEventTriggers.cpp Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add new TC_EEVSE_2_9.py which is a candidate for next release
[This PR is based on https://github.com//pull/39565 - once merged this PR is smaller]
New Test cases are in Test Plan PR: https://github.com/CHIP-Specifications/chip-test-plans/pull/5235
Related issues
N/A - New feature
Testing
New Python test case TC_EEVSE_2_9.py has been validated as part of CI.
Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)
See: Pull Request Guidelines