Increase unit test code coverage of ble/ by 1.3%
#39711
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
There was a problem hiding this comment.
Code Review
This pull request adds three new unit tests to TestBtpEngine.cpp to increase code coverage for BtpEngine. The new tests verify the initial state of sequence numbers and the behavior of acknowledgment handling. I've suggested a few changes to make the tests more accurate and robust, including correcting a check for unacknowledged data, fixing a typo, and adding an assertion to verify state changes after receiving an acknowledgment. The style guide was followed by correcting a typo.
|
PR #39711: Size comparison from 230883d to cd294f4 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #39711: Size comparison from 230883d to b34db3f Increases above 0.2%:
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
b34db3f to
f43bf66
Compare
|
PR #39711: Size comparison from f56e796 to f43bf66 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
heinsaar
reviewed
Jun 26, 2025
andy31415
reviewed
Jun 26, 2025
f43bf66 to
1ab9022
Compare
|
PR #39711: Size comparison from 41c7192 to 1ab9022 Full report (7 builds for cc32xx, qpg, stm32, tizen)
|
|
PR #39711: Size comparison from 41c7192 to 3ea231f Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
3ea231f to
d64b7f9
Compare
d64b7f9 to
f43bf66
Compare
|
PR #39711: Size comparison from 2a72083 to f43bf66 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
- Test that the initial value of the last received sequence number is zero. - Test that the initial value of the newest unacknowledged sent sequence number is zero. - Test that sending a packet updates the unacknowledged sequence number correctly and that receiving an acknowledgment updates the state as expected.
f43bf66 to
38c8043
Compare
|
PR #39711: Size comparison from 9100f28 to 38c8043 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
029fd85 to
38c8043
Compare
|
PR #39711: Size comparison from 1f6cf70 to 38c8043 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
heinsaar
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds three new test cases to
TestBtpEngine.cppto improve coverage of theBtpEngine’s sequence number and acknowledgment handling. These tests verify the initial state of sequence numbers and the correct update of state after sending and acknowledging packets.LastReceivedSequenceNumberInitialverifies that the initial value of the last received sequence number is zero when the BtpEngine is initialized.NewestUnackedSentSequenceNumberInitialensures that the newest unacknowledged sent sequence number is zero at initialization.NewestUnackedSentSequenceNumberSendtests the update of the unacknowledged sent sequence number after sending a packet and receiving an acknowledgment.Related issues
Main issue N 37232
Testing
This PR only adds new unit tests. No changes made to production code.
Coverage Impact of
BtpEngine.cpp/blefolderNote: The test cases in this PR target inline functions, which I verified that LCOV correctly identifies and generates symbols for.
Nevertheless, LCOV doesn't seem to be very good at attributing line coverage back to their original definitions for inlined functions (probably when the functions are trivial and the compiler optimizes more aggressively).
As a result:
BtpEngine.cppinstead ofBtpEngine.hwhere those inline functions are defined.