Python framework API cleanup: Move SetupParameters into commissioning.py #39732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/python_testing/matter_testing_infrastructure/chip/testing/commissioning.py
Outdated
Show resolved
Hide resolved
|
PR #39732: Size comparison from 2a523d5 to 978a24d Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
r-recchia
approved these changes
Jul 1, 2025
cecille
approved these changes
Jul 8, 2025
…mport SetupPayload.
…PyApi_Cleanup_SetupParams
|
PR #39732: Size comparison from 07fe740 to 156e215 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implementing and validating the Move SetupParameters into commissioning.py #595
Fixes: #595
The task focusing on moves the
SetupParametersclass frommatter_testing.pyintocommissioning.py, as part of the ongoing cleanup of the Python test framework API.Scope
To identify all relevant files
SetupParametersusages, the following command was used:grep -r --exclude-dir=out --exclude-dir=build --exclude-dir=python_env --exclude-dir=.git "SetupParameters" .Files In Scope
These files contain direct references or definitions of
SetupParameters:Files Out of scope
The following directories were intentionally excluded because they are auto-generated during build or part of the environment and will regenerate automatically:
out/ directory and its contentsbuild/ directory and its contentspython_env/ directory (virtual environment).git/ directory and metadataNote: The
SetupParametersclass is currently located inmatter_testing.py. Since bothmatter_testing.pyandcommissioning.pycan be modified by multiple contributors, be cautious of merge conflicts during this refactor.Related Issues & PRs
Move SetupParameters into commissioning.py #595
Python framework API cleanup #443
Testing