Updates MdnsDiscovery class (and TC-SC-4.3 to match updates) #39737
+681
−313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Code Review
The pull request updates the mdns class and TC-SC-4.3 test case. The changes include adding new methods for retrieving SRV, TXT, and AAAA records, improving error han 8000 dling, and refactoring some of the existing code. The code review identified opportunities to improve error handling, logging, and documentation.
|
PR #39737: Size comparison from 41c7192 to 796d6ec Full report (3 builds for cc32xx, stm32)
|
|
PR #39737: Size comparison from 06523c2 to 1ec8aa9 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #39737: Size comparison from e3d8447 to 613631c Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #39737: Size comparison from 43d34a0 to 5ad6ce6 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #39737: Size comparison from 206d72c to 8076e69 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #39737: Size comparison from 206d72c to 0f62216 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #39737: Size comparison from 34d3e1e to d24df3e Full report (20 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
|
|
PR #39737: Size comparison from 34d3e1e to 5c891a0 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #39737: Size comparison from 34d3e1e to f17445a Full report (3 builds for cc32xx, stm32)
|
|
PR #39737: Size comparison from 34d3e1e to aa037d8 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #39737: Size comparison from 42bfcf3 to 8685ae8 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
Main Fixes
PTR record info retrieval failure (#37154 and #524)
AAAA record info retrieval failure (came up during SVE but no issue was filed)
Ensures no mDNS info is retrieved from cache
Also included in this PR
Deprecated
get_service_by_record_typeThe get_service_by_record_type function was deprecated in favor of individual functions per record type:
get_srv_recordget_txt_recordget_quada_recordsget_ptr_recordsThis is better for maintainability and clarity, especially when addressing specific record type issues.
Using AsyncZeroconf
Improved AAAA record handling
QuadaRecordclass.Improved PTR record handling
PtrRecordclass.Added the
unlock_serviceflag to the_get_servicediscovery functionImproved logging for
get_service_typesfunction