8000 Fix null pointer dereference in function MdnsAvahi::Resolve by mugitya03 · Pull Request #39844 · project-chip/connectedhomeip · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix null pointer dereference in function MdnsAvahi::Resolve #39844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix null pointer dereference in function MdnsAvahi::Resolve #39844

wants to merge 2 commits into from
+9 −4

Conversation

mugitya03
Copy link

Summary

The function AllocateResolveContext returns a null pointer if fails to create a new object. The NULL value potentially returned by AllocateResolveContext() is dereferenced without a null check, causing a null pointer dereference bug.

Testing

Verified using static analysis and manual review:

  • Identified the issue with a static analyzer and confirmed it through code inspection.
  • Applied this patch and re-ran the analysis, confirming that the bug report no longer appears.

@jinyaoguo
Fix null pointer dereference in function MdnsAvahi::Resolve
9436c9b 
The function AllocateResolveContext returns a null pointer if fails to create a new object.
The NULL value potentially returned by AllocateResolveContext() is dereferenced without a null check, causing a null pointer dereference bug.
gemini-code-assist[bot]
gemini-code-assist bot reviewed Jul 3, 2025
View reviewed changes
Copy link
Contributor
@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly identifies and fixes a critical null pointer dereference in MdnsAvahi::Resolve by adding a null check for the context returned by AllocateResolveContext. The fix is sound and prevents a potential crash. I've added one suggestion to use a project-specific helper macro to make the error handling more concise and consistent with what appears to be a common pattern in the codebase.

@andy31415
Copy link
Contributor

@mugitya03 please apply the restyle update to make restyler happy:

{ base64 -d - | git am; } <<'EOM'
RnJvbSBkZGIzOGJkNmRlOTlkOGQ0YjEyYWNjZmIxM2IwNmQ5MzFmNWI4ZGUzIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiAiUmVzdHlsZWQuaW8iIDxjb21taXRzQHJlc3R5bGVkLmlvPgpE
YXRlOiBUaHUsIDMgSnVsIDIwMjUgMTk6MjM6MzQgKzAwMDAKU3ViamVjdDogW1BBVENIXSBSZXN0
eWxlZCBieSBjbGFuZy1mb3JtYXQKCi0tLQogc3JjL3BsYXRmb3JtL0xpbnV4L0Ruc3NkSW1wbC5j
cHAgfCA4ICsrKystLS0tCiAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA0IGRlbGV0
aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9wbGF0Zm9ybS9MaW51eC9EbnNzZEltcGwuY3BwIGIv
c3JjL3BsYXRmb3JtL0xpbnV4L0Ruc3NkSW1wbC5jcHAKaW5kZXggYjE1Y2Q0NDEuLjUxOGQ5YjFi
IDEwMDY0NAotLS0gYS9zcmMvcGxhdGZvcm0vTGludXgvRG5zc2RJbXBsLmNwcAorKysgYi9zcmMv
cGxhdGZvcm0vTGludXgvRG5zc2RJbXBsLmNwcApAQCAtODYyLDEwICs4NjIsMTAgQEAgQ0hJUF9F
UlJPUiBNZG5zQXZhaGk6OlJlc29sdmUoY29uc3QgY2hhciAqIG5hbWUsIGNvbnN0IGNoYXIgKiB0
eXBlLCBEbnNzZFNlcnZpY2UKICAgICAgICAgQ2hpcExvZ0Vycm9yKERpc2NvdmVyeSwgIkZhaWxl
ZCB0byBhbGxvY2F0ZSByZXNvbHZlIGNvbnRleHQiKTsKICAgICAgICAgcmV0dXJuIENISVBfRVJS
T1JfTk9fTUVNT1JZOwogICAgIH0KLSAgICBDSElQX0VSUk9SIGVycm9yICAgICAgICAgICAgICAg
ID0gQ0hJUF9OT19FUlJPUjsKLSAgICByZXNvbHZlQ29udGV4dC0+bUluc3RhbmNlICAgICAgID0g
dGhpczsKLSAgICByZXNvbHZlQ29udGV4dC0+bUNhbGxiYWNrICAgICAgID0gY2FsbGJhY2s7Ci0g
ICAgcmVzb2x2ZUNvbnRleHQtPm1Db250ZXh0ICAgICAgICA9IGNvbnRleHQ7CisgICAgQ0hJUF9F
UlJPUiBlcnJvciAgICAgICAgICA9IENISVBfTk9fRVJST1I7CisgICAgcmVzb2x2ZUNvbnRleHQt
Pm1JbnN0YW5jZSA9IHRoaXM7CisgICAgcmVzb2x2ZUNvbnRleHQtPm1DYWxsYmFjayA9IGNhbGxi
YWNrOworICAgIHJlc29sdmVDb250ZXh0LT5tQ29udGV4dCAgPSBjb250ZXh0OwogCiAgICAgaWYg
KCFpbnRlcmZhY2UuSXNQcmVzZW50KCkpCiAgICAgewotLSAKMi40OS4wCg==
EOM

@mugitya03
Copy link
Author

@andy31415 Applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

@andy31415 andy31415 andy31415 approved these changes

Assignees
No one assigned
Labels
linux platform review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mugitya03 @andy31415 @jinyaoguo @restyled-commits
0