Add a null-check on the return value of function getXTransitionStateByIndex #39848
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yIndex The function getXTransitionStateByIndex may return nullptr if index is invalid. In function updateXYCommand, the return value of getXTransitionStateByIndex is directly propagated to function computeNewColor16uValue, where it is dereferenced without any validation. I think it would be better to add a check on the return value of getXTransitionStateByIndex, as all other callsites have such checks.
There was a problem hiding this comment.
Code Review
This pull request correctly identifies and fixes a potential null pointer dereference in updateXYCommand by adding checks for the return values of getXTransitionStateByIndex and getYTransitionStateByIndex. My review points out a critical issue where the wrong macro is used for the check, which would lead to a compilation error, and provides a suggestion for the correct macro to use.
andy31415
requested changes
Jul 10, 2025
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
Sorry, I may have mistakenly applied a Copilot suggestion while editing this code. Now it has been fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The function
getXTransitionStateByIndexmay return nullptr ifindexis invalid. Inthe functionupdateXYCommand, the return value ofgetXTransitionStateByIndexis directly propagated to the functioncomputeNewColor16uValue, where it is dereferenced without any validation.I think it would be better to add a check on the return value of getXTransitionStateByIndex, as all other call sites have such checks.
Testing
Verified using static analysis and manual review: