[Camera] Python Camera Controller implementation for WEBRTC TCs #39851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
July 4, 2025 10:36
…estor server in controller and to receive commands Signed-off-by: abhishek.h <abhishek.h@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com>
…RP_OR_TCP Signed-off-by: abhishek.h <abhishek.h@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com>
Signed-off-by: abhishek.h <abhishek.h@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com>
…eiving video, sets media handlers - forward H264 packets to UDP socket so a webclient can pick it up - Adds more APIs related to peerconnection - moves WebRTCClient to a separate file Signed-off-by: abhishek.h <abhishek.h@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com>
…thods - webrtc_manager maintains mappings of sessionid, nodeid and peer_connection. Also has requestor delegate callbacks - peer_connection maintains all states of the peer both through webrtc_client and requestor commands Signed-off-by: abhishek.h <abhishek.h@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com>
…commands - This is need due to the slow processing of python responses by which time the next command for webrtc requestor would fail with NOT_FOUND by the requestor server. - To solve this custom response handling is required from the cpp itself, hence the need for a separate command sender for these commands Signed-off-by: abhishek.h <abhishek.h@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com>
Signed-off-by: Charles Kim <chulspro.kim@samsung.com>
There was a problem hiding this comment.
Code Review
This pull request introduces a significant amount of new functionality to support WebRTC in the Python controller, primarily for testing purposes. It adds new Python classes like PeerConnection and WebRTCManager to handle WebRTC sessions, a custom command sender for performance-critical paths, and the necessary C++ backend and native bindings. The changes are well-structured and modular. I've identified a critical issue with incorrect arguments being passed to native functions that will cause runtime errors, and a couple of medium-severity issues related to hardcoded values that could affect test stability and code reusability. Overall, a great addition once these points are addressed.
Signed-off-by: Charles Kim <chulspro.kim@samsung.com>
|
PR #39851: Size comparison from 02d5c4a to 16e7713 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
added 2 commits
July 5, 2025 10:00
Signed-off-by: abhishek.h <abhishek.h@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com>
Signed-off-by: Charles Kim <chulspro.kim@samsung.com>
|
PR #39851: Size comparison from 02d5c4a to 200d4e2 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
…sender callbacks Signed-off-by: abhishek.h <abhishek.h@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com>
|
PR #39851: Size comparison from 02d5c4a to 2dca94d Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
marktrayer
approved these changes
Jul 9, 2025
yufengwangca
approved these changes
Jul 9, 2025
Signed-off-by: Charles Kim <chulspro.kim@samsung.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR,
allowLargePayloadto command sender based onTransportPayloadCapabilitytypePeerConnection,WebRTCManagerclasses inchip.webrtcmodule to help manage the peer connection.PeerConnectionWEBRTC TCs 1.1, 1.2, 1.3, 1.4 will utilize class methods from
PeerConnectionandWebRTCManagerto execute test steps.Testing
Manual verification with TCs