-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Rearrange functions in MatterBaseTest #39858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Rearrange functions in MatterBaseTest #39858
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the MatterBaseTest
class, improving readability and maintainability by organizing methods and adding docstrings. I've identified and suggested fixes for a few issues, including a potential for incorrect behavior and edge cases in test step handling.
src/python_testing/matter_testing_infrastructure/chip/testing/matter_testing.py
Show resolved
Hide resolved
src/python_testing/matter_testing_infrastructure/chip/testing/matter_testing.py
Show resolved
Hide resolved
src/python_testing/matter_testing_infrastructure/chip/testing/matter_testing.py
Show resolved
Hide resolved
PR #39858: Size comparison from 39de093 to 99b5bd8 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #39858: Size comparison from ce90b61 to 16eaf47 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
src/python_testing/matter_testing_infrastructure/chip/testing/matter_testing.py
Show resolved
Hide resolved
This reverts commit 832f7ea.
Summary
This is just rearrangement of functions from MatterBaseTest according to their functionality. Relevant docstrings were improved as well.
Related issues
Resolves project-chip/matter-test-scripts#597
Testing
CI and local testing