8000 Fix spelling errors in a comment paragraph by jmartinez-silabs · Pull Request #39860 · project-chip/connectedhomeip · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix spelling errors in a comment paragraph #39860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 7, 2025
Merged

Fix spelling errors in a comment paragraph #39860

merged 2 commits into from
Jul 7, 2025

Conversation

jmartinez-silabs
Copy link
Member

Summary

This pr addresses some post-merge comments from #39461, catching spelling mistakes.

  • Fix the mistakes in the identified comment paragraph

Related issues

N/A

Testing

N/A only comment text is modified.

@github-actions github-actions bot added the app label Jul 4, 2025
@pullapprove pullapprove bot added review - pending and removed app labels Jul 4, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Jul 4, 2025
View reviewed changes
Copy link
Contributor
@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes spelling errors in a comment. A suggestion was made to add a TODO comment to track future refactoring, referencing the style guide for typo fixes.

@github-actions GitHub Actions
Copy link
github-actions bot commented Jul 4, 2025 •
edited
Loading

PR #39860: Size comparison from 860799f to 554f464

Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen) 8000
platform target config section 860799f 554f464 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1103302 1103302 0 0.0
RAM 179026 179026 0 0.0
bl702 lighting-app bl702+eth FLASH 656454 656454 0 0.0
RAM 134977 134977 0 0.0
bl702+wifi FLASH 833892 833892 0 0.0
RAM 124541 124541 0 0.0
bl706+mfd+rpc+littlefs FLASH 1066262 1066262 0 0.0
RAM 117397 117397 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 895808 895808 0 0.0
RAM 105676 105676 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 979526 979526 0 0.0
RAM 109876 109876 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 764080 764080 0 0.0
RAM 103368 103368 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 775772 775772 0 0.0
RAM 108536 108536 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 721880 721880 0 0.0
RAM 96940 96940 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 706180 706180 0 0.0
RAM 97148 97148 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 549470 549470 0 0.0
RAM 205144 205144 0 0.0
lock CC3235SF_LAUNCHXL FLASH 582590 582590 0 0.0
RAM 205344 205344 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 663541 663541 0 0.0
RAM 77472 77472 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 683385 683385 0 0.0
RAM 80112 80112 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 683385 683385 0 0.0
RAM 80112 80112 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 640325 640325 0 0.0
RAM 72540 72540 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 624917 624917 0 0.0
RAM 73784 73784 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 644545 644545 0 0.0
RAM 76336 76336 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 644545 644545 0 0.0
RAM 76336 76336 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 645853 645853 0 0.0
RAM 76784 76784 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 665561 665561 0 0.0
RAM 79336 79336 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 665561 665561 0 0.0
RAM 79336 79336 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 620529 620529 0 0.0
RAM 70888 70888 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 640381 640381 0 0.0
RAM 73520 73520 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 640381 640381 0 0.0
RAM 73520 73520 0 0.0
efr32 lock-app BRD4187C FLASH 948148 948148 0 0.0
RAM 131528 131528 0 0.0
BRD4338a FLASH 745604 745596 -8 -0.0
RAM 206896 206896 0 0.0
window-app BRD4187C FLASH 1041512 1041504 -8 -0.0
RAM 127656 127656 0 0.0
esp32 all-clusters-app c3devkit DRAM 102272 102272 0 0.0
FLASH 1781456 1781456 0 0.0
IRAM 83862 83862 0 0.0
m5stack DRAM 121156 121156 0 0.0
FLASH 1748690 1748690 0 0.0
IRAM 117071 117071 0 0.0
linux air-purifier-app debug unknown 4848 4848 0 0.0
FLASH 2798168 2798168 0 0.0
RAM 117384 117384 0 0.0
all-clusters-app debug unknown 5664 5664 0 0.0
FLASH 6201702 6201702 0 0.0
RAM 531264 531264 0 0.0
all-clusters-minimal-app debug unknown 5528 5528 0 0.0
FLASH 5475538 5475538 0 0.0
RAM 228088 228088 0 0.0
bridge-app debug unknown 5560 5560 0 0.0
FLASH 4808818 4808818 0 0.0
RAM 207776 207776 0 0.0
camera-app debug unknown 8968 8968 0 0.0
FLASH 6935563 6935563 0 0.0
RAM 230088 230088 0 0.0
camera-controller debug unknown 9184 9184 0 0.0
FLASH 14373755 14373755 0 0.0
RAM 661336 661336 0 0.0
chip-tool debug unknown 6240 6240 0 0.0
FLASH 14721407 14721407 0 0.0
RAM 654856 654856 0 0.0
chip-tool-ipv6only arm64 unknown 40648 40648 0 0.0
FLASH 12698415 12698415 0 0.0
RAM 701152 701152 0 0.0
fabric-admin debug unknown 5920 5920 0 0.0
FLASH 12784861 12784861 0 0.0
RAM 653848 653848 0 0.0
fabric-bridge-app debug unknown 4808 4808 0 0.0
FLASH 4594998 4594998 0 0.0
RAM 193536 193536 0 0.0
fabric-sync debug unknown 5056 5056 0 0.0
FLASH 5744381 5744381 0 0.0
RAM 491728 491728 0 0.0
lighting-app debug+rpc+ui unknown 6272 6272 0 0.0
FLASH 5657729 5657729 0 0.0
RAM 209928 209928 0 0.0
lock-app debug unknown 5488 5488 0 0.0
FLASH 4839012 4839012 0 0.0
RAM 197160 197160 0 0.0
ota-provider-app debug unknown 4848 4848 0 0.0
FLASH 4447664 4447664 0 0.0
RAM 186224 186224 0 0.0
ota-requestor-app debug unknown 4728 4728 0 0.0
FLASH 4519822 4519822 0 0.0
RAM 189064 189064 0 0.0
shell debug unknown 4256 4256 0 0.0
FLASH 3081004 3081004 0 0.0
RAM 147328 147328 0 0.0
thermostat-no-ble arm64 unknown 9800 9800 0 0.0
FLASH 4236247 4236247 0 0.0
RAM 233392 233392 0 0.0
tv-app debug unknown 5824 5824 0 0.0
FLASH 6108701 6108701 0 0.0
RAM 615960 615960 0 0.0
tv-casting-app debug unknown 5336 5336 0 0.0
FLASH 12872445 12872445 0 0.0
RAM 771360 771360 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 889212 889212 0 0.0
RAM 166162 166162 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 897256 897256 0 0.0
RAM 145100 145100 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 859740 859740 0 0.0
RAM 141049 141049 0 0.0
nxp contact mcxw71+release FLASH 625824 625824 0 0.0
RAM 63164 63164 0 0.0
lock mcxw71+release FLASH 777056 777056 0 0.0
RAM 67820 67820 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1632916 1632916 0 0.0
RAM 211104 211104 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1577108 1577108 0 0.0
RAM 208472 208472 0 0.0
light cy8ckit_062s2_43012 FLASH 1449708 1449708 0 0.0
RAM 197184 197184 0 0.0
lock cy8ckit_062s2_43012 FLASH 1482076 1482076 0 0.0
RAM 224904 224904 0 0.0
qpg lighting-app qpg6200+debug FLASH 744800 744800 0 0.0
RAM 94220 94220 0 0.0
lock-app qpg6200+debug FLASH 754572 754572 0 0.0
RAM 94248 94248 0 0.0
stm32 light STM32WB5MM-DK FLASH 466252 466252 0 0.0
RAM 141376 141376 0 0.0
telink bridge-app tl7218x FLASH 703352 703352 0 0.0
RAM 93600 93600 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 795066 795066 0 0.0
RAM 44016 44016 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 783472 783472 0 0.0
RAM 100912 100912 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 710778 710778 0 0.0
RAM 54240 54240 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 747352 747352 0 0.0
RAM 77404 77404 0 0.0
light-switch-app-ota-factory-data tl3218x_retention FLASH 724098 724098 0 0.0
RAM 36996 36996 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 603650 603650 0 0.0
RAM 112532 112532 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 819046 819050 4 0.0
RAM 99164 99164 0 0.0
tizen all-clusters-app arm unknown 5100 5100 0 0.0
FLASH 1698072 1698072 0 0.0
RAM 91472 91472 0 0.0
chip-tool-ubsan arm unknown 20752 20752 0 0.0
FLASH 21031098 21031098 0 0.0
RAM 9154436 9154436 0 0.0

@github-actions github-actions bot added the app label Jul 7, 2025
@github-actions GitHub Actions
Copy link
github-actions bot commented Jul 7, 2025 •
edited
Loading

PR #39860: Size comparison from 4a0a8cf to d111d80

Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen) 8000
platform target config section 4a0a8cf d111d80 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1103324 1103324 0 0.0
RAM 179026 179026 0 0.0
bl702 lighting-app bl702+eth FLASH 656474 656474 0 0.0
RAM 134977 134977 0 0.0
bl702+wifi FLASH 833912 833912 0 0.0
RAM 124541 124541 0 0.0
bl706+mfd+rpc+littlefs FLASH 1066284 1066284 0 0.0
RAM 117397 117397 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 895830 895830 0 0.0
RAM 105676 105676 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 979548 979548 0 0.0
RAM 109876 109876 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 764096 764096 0 0.0
RAM 103368 103368 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 775772 775772 0 0.0
RAM 108536 108536 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 721904 721904 0 0.0
RAM 96940 96940 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 706204 706204 0 0.0
RAM 97148 97148 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 549482 549482 0 0.0
RAM 205144 205144 0 0.0
lock CC3235SF_LAUNCHXL FLASH 582602 582602 0 0.0
RAM 205344 205344 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 663549 663549 0 0.0
RAM 77472 77472 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 683401 683401 0 0.0
RAM 80112 80112 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 683401 683401 0 0.0
RAM 80112 80112 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 640341 640341 0 0.0
RAM 72540 72540 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 624933 624933 0 0.0
RAM 73784 73784 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 644569 644569 0 0.0
RAM 76336 76336 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 644569 644569 0 0.0
RAM 76336 76336 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 645885 645885 0 0.0
RAM 76784 76784 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 665601 665601 0 0.0
RAM 79336 79336 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 665601 665601 0 0.0
RAM 79336 79336 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 620561 620561 0 0.0
RAM 70888 70888 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 640413 640413 0 0.0
RAM 73520 73520 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 640413 640413 0 0.0
RAM 73520 73520 0 0.0
efr32 lock-app BRD4187C FLASH 948196 948196 0 0.0
RAM 131528 131528 0 0.0
BRD4338a FLASH 745636 745628 -8 -0.0
RAM 206896 206896 0 0.0
window-app BRD4187C FLASH 1041528 1041520 -8 -0.0
RAM 127656 127656 0 0.0
esp32 all-clusters-app c3devkit DRAM 102272 102272 0 0.0
FLASH 1781550 1781550 0 0.0
IRAM 83862 83862 0 0.0
m5stack DRAM 121156 121156 0 0.0
FLASH 1748798 1748798 0 0.0
IRAM 117071 117071 0 0.0
linux air-purifier-app debug unknown 4848 4848 0 0.0
FLASH 2799424 2799424 0 0.0
RAM 117416 117416 0 0.0
all-clusters-app debug unknown 5664 5664 0 0.0
FLASH 6203030 6203030 0 0.0
RAM 531312 531312 0 0.0
all-clusters-minimal-app debug unknown 5528 5528 0 0.0
FLASH 5476690 5476690 0 0.0
RAM 228104 228104 0 0.0
bridge-app debug unknown 5560 5560 0 0.0
FLASH 4810004 4810004 0 0.0
RAM 207808 207808 0 0.0
camera-app debug unknown 8968 8968 0 0.0
FLASH 6936891 6936891 0 0.0
RAM 230120 230120 0 0.0
camera-controller debug unknown 9184 9184 0 0.0
FLASH 14373803 14373803 0 0.0
RAM 661336 661336 0 0.0
chip-tool debug unknown 6240 6240 0 0.0
FLASH 14721465 14721465 0 0.0
RAM 654880 654880 0 0.0
chip-tool-ipv6only arm64 unknown 40648 40648 0 0.0
FLASH 12698511 12698511 0 0.0
RAM 701176 701176 0 0.0
fabric-admin debug unknown 5920 5920 0 0.0
FLASH 12784919 12784919 0 0.0
RAM 653880 653880 0 0.0
fabric-bridge-app debug unknown 4808 4808 0 0.0
FLASH 4596220 4596220 0 0.0
RAM 193552 193552 0 0.0
fabric-sync debug unknown 5056 5056 0 0.0
FLASH 5745613 5745613 0 0.0
RAM 491728 491728 0 0.0
lighting-app debug+rpc+ui unknown 6272 6272 0 0.0
FLASH 5658945 5658945 0 0.0
RAM 209944 209944 0 0.0
lock-app debug unknown 5488 5488 0 0.0
FLASH 4840238 4840238 0 0.0
RAM 197192 197192 0 0.0
ota-provider-app debug unknown 4848 4848 0 0.0
FLASH 4448818 4448818 0 0.0
RAM 186240 186240 0 0.0
ota-requestor-app debug unknown 4728 4728 0 0.0
FLASH 4520976 4520976 0 0.0
RAM 189112 189112 0 0.0
shell debug unknown 4256 4256 0 0.0
FLASH 3081132 3081132 0 0.0
RAM 147344 147344 0 0.0
thermostat-no-ble arm64 unknown 9832 9832 0 0.0
FLASH 4237071 4237071 0 0.0
RAM 233416 233416 0 0.0
tv-app debug unknown 5824 5824 0 0.0
FLASH 6109853 6109853 0 0.0
RAM 615976 615976 0 0.0
tv-casting-app debug unknown 5336 5336 0 0.0
FLASH 12874317 12874317 0 0.0
RAM 771472 771472 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 889236 889236 0 0.0
RAM 166162 166162 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 897264 897264 0 0.0
RAM 145100 145100 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 859760 859760 0 0.0
RAM 141049 141049 0 0.0
nxp contact mcxw71+release FLASH 625840 625840 0 0.0
RAM 63164 63164 0 0.0
lock mcxw71+release FLASH 777080 777080 0 0.0
RAM 67820 67820 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1632948 1632948 0 0.0
RAM 211104 211104 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1577140 1577140 0 0.0
RAM 208472 208472 0 0.0
light cy8ckit_062s2_43012 FLASH 1449724 1449724 0 0.0
RAM 197184 197184 0 0.0
lock cy8ckit_062s2_43012 FLASH 1482108 1482108 0 0.0
RAM 224904 224904 0 0.0
qpg lighting-app qpg6200+debug FLASH 744824 744824 0 0.0
RAM 94220 94220 0 0.0
lock-app qpg6200+debug FLASH 754580 754580 0 0.0
RAM 94248 94248 0 0.0
stm32 light STM32WB5MM-DK FLASH 466276 466276 0 0.0
RAM 141376 141376 0 0.0
telink bridge-app tl7218x FLASH 703360 703360 0 0.0
RAM 93600 93600 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 795074 795074 0 0.0
RAM 44016 44016 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 783480 783480 0 0.0
RAM 100912 100912 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 710786 710786 0 0.0
RAM 54240 54240 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 747360 747360 0 0.0
RAM 77404 77404 0 0.0
light-switch-app-ota-factory-data tl3218x_retention FLASH 724106 724106 0 0.0
RAM 36996 36996 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 603658 603658 0 0.0
RAM 112532 112532 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 819054 819058 4 0.0
RAM 99164 99164 0 0.0
tizen all-clusters-app arm unknown 5096 5096 0 0.0
FLASH 1698804 1698804 0 0.0
RAM 91444 91444 0 0.0
chip-tool-ubsan arm unknown 20752 20752 0 0.0
FLASH 21031146 21031146 0 0.0
RAM 9154448 9154448 0 0.0

@mergify mergify bot merged commit ef81fc1 into project-chip:master Jul 7, 2025
70 checks passed
@jmartinez-silabs jmartinez-silabs deleted the 39461_post_merge_comments branch July 7, 2025 22:18
dsavitsky-dsr pushed a commit to dsavitsky-dsr/connectedhomeip that referenced this pull request Jul 9, 2025
@jmartinez-silabs @bzbarsky-apple @dsavitsky-dsr
Fix comments spelling errors (project-chip#39860)
f243a56 81A6 
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

@enkiusz enkiusz enkiusz approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@mkardous-silabs mkardous-silabs mkardous-silabs approved these changes

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmartinez-silabs @enkiusz @bzbarsky-apple @mkardous-silabs
0