Fix Python wheel for IDT so that it includes all the necessary files. #39861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Code Review
This pull request fixes the matter-post-certification-tests Python wheel by adding a new BUILD.gn file to ensure all necessary files are included with the correct directory structure. The changes look correct and address the issue described. I've added a few suggestions to improve the readability and maintainability of the new build file.
|
PR #39861: Size comparison from 860799f to b6ccb9a Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
cecille
approved these changes
Jul 4, 2025
|
PR #39861: Size comparison from 4944739 to 86fa143 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
arkq
approved these changes
Jul 7, 2025
dsavitsky-dsr
pushed a commit
to dsavitsky-dsr/connectedhomeip
that referenced
this pull request
Jul 7, 2025
…project-chip#39861) * build a wheel * remove authors * addressing gemini comments * add __init__.py to setuptools * Restyled by gn --------- Co-authored-by: Restyled.io <commits@restyled.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the
matter-post-certification-testsPython wheel so that it includes all the necessary files.setuptoolsneeds__init__.pyin order to recoginze a folder as a Python package, this is needed in order to create the folder hierarchy inside the Python wheel:chip/testing/idt/Related issues
Fixes: project-chip/matter-test-scripts#559
Testing
Created a Python wheel manually and verified that it contains all the necessary files.