[darwin-framework-tool] Enable operational advertisement for per cont… #39865
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fast track: platform-specific changes made by platform maintainer. |
There was a problem hiding this comment.
Code Review
This pull request enables operational advertisements when using darwin-framework-tool with per-controller storage, which is the default. The change is a one-line addition to set shouldAdvertiseOperational to YES during controller setup. This appears to be a straightforward bug fix that restores expected behavior, and the implementation is correct and consistent with the surrounding code. I have no further comments.
|
PR #39865: Size comparison from 587b904 to 47a6930 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #39865: Size comparison from ddb2cbf to 08ee9d8 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…roller storage
Summary
When
darwin-framework-toolis used with per-controller storage (the default), operational advertisements are not emitted.Related issues
N/A
Testing
Run
./out/debug/standalone/darwin-framework-tool interactive startand look at the logs.Without this patch: No operational advertisements
With this patch: Operational advertisements run as expected.