Linux: Move UniqueId from ChipFactory to ChipConfig namespace #39879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The UniqueId must be cleared on factory reset, so it does not belong in the factory namespace. See project-chip#39852.
There was a problem hiding this comment.
Code Review
The code changes move the UniqueId to the ChipConfig namespace and include data migration logic. There's a potential issue with error handling in the migration logic that could mask failures during the migration process. The suggested change ensures that any errors are properly propagated, leading to a more reliable system.
|
PR #39879: Size comparison from ce90b61 to 96192a2 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jmartinez-silabs
approved these changes
Jul 8, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR moves the UniqueId key out of the factory namespace into the chip configuration namespace so that it gets cleared on factory reset, and adds migration logic on Linux to move any existing stored value.
- Changed the
UniqueIdkey namespace in both Linux and Darwin implementations fromChipFactorytoChipConfig. - Added fallback and migration logic in Linux
ReadConfigValueStrto read from the old factory namespace and re-write into the new one.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/platform/Linux/PosixConfig.cpp | Updated UniqueId namespace and added migration code on read |
| src/platform/Darwin/PosixConfig.cpp | Moved UniqueId declaration to ChipConfig namespace |
kiel-apple
approved these changes
Jul 8, 2025
dsavitsky-dsr
pushed a commit
to dsavitsky-dsr/connectedhomeip
that referenced
this pull request
Jul 9, 2025
…t-chip#39879) * Linux: Move UniqueId from ChipFactory to ChipConfig namespace The UniqueId must be cleared on factory reset, so it does not belong in the factory namespace. See project-chip#39852. * Make the linter happy and improve comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The UniqueId must be cleared on factory reset, so it does not belong in the factory namespace. See #39852.
Testing
Existing CI tests. Manually tested the migration code path.