[Cameras] Add Alchemy generated XML for all Camera device types #39891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Code Review
This pull request introduces new camera device types and updates existing ones, generated via the Alchemy tool. The changes also include extensive XML formatting updates for consistency. The new device definitions and formatting changes are mostly sound, but I've identified one critical issue where a new device type is missing a required element, which could lead to processing failures.
|
PR #39891: Size comparison from 961f1c3 to 3ecf51e Full report (3 builds for cc32xx, stm32)
|
|
PR #39891: Size comparison from 961f1c3 to 1f6a844 Full report (3 builds for cc32xx, stm32)
|
|
PR #39891: Size comparison from 961f1c3 to 5208bc0 Full report (3 builds for cc32xx, stm32)
|
|
PR #39891: Size comparison from 4a0a8cf to 6efe3c1 Full report (3 builds for cc32xx, stm32)
|
|
PR #39891: Size comparison from 4a0a8cf to 1a348d1 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yufengwangca
approved these changes
Jul 8, 2025
chulspro
approved these changes
Jul 8, 2025
dsavitsky-dsr
pushed a commit
to dsavitsky-dsr/connectedhomeip
that referenced
this pull request
Jul 9, 2025
…ect-chip#39891) * Add Alchemy generated XML for all Camera device types * Undo inadvertant back out of other in-progress work * Add results of Zap regen * Rerun regen after matter-devices update * Add omitted Zap generated file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Via Alchemy, generate new XML for all Camera defined device types that is present in matter-devices.xml
Testing
Run Zap re-gen
Clean CI
Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)
See: Pull Request Guidelines