[Silabs] 917SoC Linker file fix #39807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Code Review
This pull request updates the linker script for the Silabs 917 SoC, likely to align with a new SDK version. The changes involve memory region adjustments, modifications to section placements, and an updated data initialization approach. My review found a critical typo in the .eh_frame section name which could lead to runtime failures. I have provided a suggestion to correct it.
|
In the PR description, |
|
PR #39807: Size comparison from 9151e79 to e7d0627 Increases above 0.2%:
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
jmartinez-silabs
approved these changes
Jul 2, 2025
Provide more details on what was tested/how it was tested |
Ohh okay, updated the testing part. |
soares-sergio
approved these changes
Jul 2, 2025
senthilku
approved these changes
Jul 3, 2025
|
PR #39807: Size comparison from dda2252 to 6cbb740 Increases above 0.2%:
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
dsavitsky-dsr
pushed a commit
to dsavitsky-dsr/connectedhomeip
that referenced
this pull request
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
917 SoC linker file was reverted in the PR #39562
Fixed the linker file with the latest sdk
The issue was the file excluded and included were in incorrect format
*filename.o which is used in the extension
*filename.c.o used in the ninja build system
Testing
Tested locally with 917 SoC Commissioning and commands.
Reverted the PR, just to confirm it fails with v3.5.0, it fails with the same error.