[NXP][CMake][MCXW7x] Fix low-power app flavors not operating in low-power mode #39837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Code Review
This pull request introduces fixes to enable low-power mode for NXP MCXW7x platforms. The changes include adjustments to ICD parameters, switching to sleepy end device mode, and disabling power-consuming features. Several comments have been added to verify the correctness and intended behavior of the changes, especially concerning default values and potential regressions.
|
PR #39837: Size comparison from b6f0333 to 56f566c Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
chapongatien
approved these changes
Jul 4, 2025
56f566c to
4241c8d
Compare
|
PR #39837: Size comparison from 4944739 to 4241c8d Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com> Reviewed-by: Marian Chereji <marian.chereji@nxp.com>
…_DISCOVERY in CMake build Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com> Reviewed-by: Marian Chereji <marian.chereji@nxp.com>
…g in low-power mode The low-power build configurations of the Matter apps for MCXW7x platforms were not operating in low-power mode due to the fact that an incorrect configuration of build flags was being used. Signed-off-by: Marian Chereji <marian.chereji@nxp.com>
…sBle.cpp The "UserInterfaceFeedback.h" header is only required to be included when UI feedback is enabled. Otherwise it breaks the CMake build for app flavors that are not using UI feedback. Signed-off-by: Marian Chereji <marian.chereji@nxp.com>
…r low-power applications The APP_QUEUE_TICKS_TO_WAIT configuration value is dictating how frequent the main Matter application thread is querying the event queues. For low-power build configurations this frequency needs to be low enough in order for the application to be able to reach low-power states. Signed-off-by: Marian Chereji <marian.chereji@nxp.com>
4241c8d to
0233c14
Compare
|
PR #39837: Size comparison from ce90b61 to 0233c14 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
soares-sergio
approved these changes
Jul 8, 2025
dsavitsky-dsr
pushed a commit
to dsavitsky-dsr/connectedhomeip
that referenced
this pull request
Jul 9, 2025
…ower mode (project-chip#39837) * [NXP][cmake] Updates to align GN and CMake builds for MCXW platforms Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com> Reviewed-by: Marian Chereji <marian.chereji@nxp.com> * [NXP][cmake][platform][mcxw71] Fix CHIP_DEVICE_CONFIG_ENABLE_EXTENDED_DISCOVERY in CMake build Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com> Reviewed-by: Marian Chereji <marian.chereji@nxp.com> * [NXP][cmake][examples][mcxw7x] Fix low-power app flavors not operating in low-power mode The low-power build configurations of the Matter apps for MCXW7x platforms were not operating in low-power mode due to the fact that an incorrect configuration of build flags was being used. Signed-off-by: Marian Chereji <marian.chereji@nxp.com> * [NXP][examples][common] Fix incorrect header include guards in ButtonsBle.cpp The "UserInterfaceFeedback.h" header is only required to be included when UI feedback is enabled. Otherwise it breaks the CMake build for app flavors that are not using UI feedback. Signed-off-by: Marian Chereji <marian.chereji@nxp.com> * [NXP][cmake][examples][common] Fix APP_QUEUE_TICKS_TO_WAIT too low for low-power applications The APP_QUEUE_TICKS_TO_WAIT configuration value is dictating how frequent the main Matter application thread is querying the event queues. For low-power build configurations this frequency needs to be low enough in order for the application to be able to reach low-power states. Signed-off-by: Marian Chereji <marian.chereji@nxp.com> --------- Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com> Signed-off-by: Marian Chereji <marian.chereji@nxp.com> Co-authored-by: dinabenamar <108664279+dinabenamar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request proposes several fixes to enable CMake generated applications for NXP MCXW7x platforms to properly operate in low-power mode.
Testing
Manually tested.