Fix venv created by build_python.sh to include minimal build requirements #1 #39944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without it, for example python_path required by "build_examples.py" could be missing in out/python_env
Fix venv created by build_python.sh to include minimal build requirements
There was a problem hiding this comment.
Code Review
This pull request correctly addresses an issue with missing build dependencies in the Python virtual environment by adding an installation step for requirements.build.txt. My review includes a suggestion to enhance this change for better build reproducibility and consistency with other parts of the project's setup scripts.
|
PR #39944: Size comparison from f420a03 to f7cb88f Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
cecille
approved these changes
Jul 10, 2025
tersal
approved these changes
Jul 11, 2025
bauerschwan
approved these changes
8000
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding scripts/setup/requirements.build.txt in the python venv created by build_python.sh to be able to run "build_examples.py"
Related issues
Without this change, when following the instructions in running-yaml-tests, I had python_path module missing from out/python_env because it was not a requirement when this venv is created.
Testing
In my installation, the instructions in running-yaml-tests now run fine.
Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)