-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[silabs] Add Silicon Labs config folder #39947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new Zephyr basic configuration for Silicon Labs, adding a comprehensive set of files including CMake build scripts, Kconfig options, and GN build configurations. This lays the groundwork for building Matter applications on Silabs platforms. My review has identified a critical build configuration error in module.yml
that will likely cause build failures. Additionally, there are a few high-severity issues in common.cmake
related to incorrect Kconfig variables and a suspicious include path from another vendor's configuration. Several medium-severity issues, such as copy-paste errors, typos in help texts, and missing newlines, have also been noted. Addressing these points will improve the correctness and maintainability of this new platform support.
PR #39947: Size comparison from 43234ba to 0e6bacb Full report (63 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
0e6bacb
to
919574e
Compare
PR #39947: Size comparison from 43234ba to 919574e Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Summary
Add Zephyr basic configuration for Silicon Labs
Related issues
None
Testing
Internal testing. As the implementation is not completed, the configuration by itself won't break anything and won't be usable until all relevant PR are merged