Tc drlk 2 1 #39948
Open
Tc drlk 2 1 #39948
+54
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DRLK.S.A0004=1 DRLK.S.A0005=1 DRLK.S.A0006=1
<
8000
div class="js-socket-channel js-updatable-content" data-channel="eyJjIjoicmVwbzoyNDQ2OTQxNzQ6Y29tbWl0OmMwMWYwYzEyMTc1MjkzMjE0MzU4OGYwNDZmNTQwNDFmZGFmNzZhNTYiLCJ0IjoxNzUyMzg0NjQ3fQ==--fcdf3c5feeda43e19756ac3348fb504440f0f437890832761992ddd0edcfd149" data-url="/project-chip/connectedhomeip/pull/39948/partials/commit_status_icon?oid=c01f0c121752932143588f046f54041fdaf76a56">
There was a problem hiding this comment.
Code Review
This pull request updates the door lock test suite Test_TC_DRLK_2_1.yaml and the corresponding PICS values for CI. The changes involve correcting test step logic, fixing values, and enabling more features for testing. The changes are generally good, but I've pointed out a typo in a PICS identifier that should be corrected for consistency and maintainability.
| - label: "Step 32d: TH writes UserCodeTemporaryDisableTime attribute as 0" | ||
| PICS: | ||
| " ( DRLK.S.F00 || DRLK.S.F01 ) && DRLK.S.A0031 && | ||
| DRLK.S.M.UserCodedTemporaryDisableTimeAttributeWritable " |
There was a problem hiding this comment.
There appears to be a typo in the PICS identifier DRLK.S.M.UserCodedTemporaryDisableTimeAttributeWritable. It should likely be DRLK.S.M.UserCodeTemporaryDisableTimeAttributeWritable (without the 'd' in 'Coded'). This typo is also present on line 1422.
While this seems to be consistent with the definition in PICS.yaml, it would be good to correct this for consistency with the attribute name (UserCodeTemporaryDisableTime) and to prevent future confusion. You might need to update PICS.yaml and ci-pics-values as well to fully resolve this.1
DRLK.S.M.UserCodeTemporaryDisableTimeAttributeWritable "
Style Guide References
Footnotes
|
PR #39948: Size comparison from 43234ba to c01f0c1 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #39948: Size comparison from c0a78ce to e4b7de9 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
juandediosg
reviewed
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
This PR updates Test_TC_DRLK_2_1.yaml and Fixes #492
Updated steps 5c and 6c
Updated ci-pics-values
Set maxValue to 255 in steps 11a, 12a and 13a
Corrected step 31d
Added missing step 32d
Updated values for steps 40b, 42b
Updated PICs for steps 42a/b/c, 43a/b/c and 44a/b/c