Implement an abstraction layer for WebRTC stack #39953
Merged
+413
−166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Code Review
The code changes introduce an abstraction layer for the WebRTC stack, decoupling the application from the libdatachannel library. This involves creating abstract interfaces for WebRTCPeerConnection and WebRTCTrack, along with a factory function to create WebRTCPeerConnection instances. The changes also include modifications to the WebRTC provider manager and transport classes to use the new abstraction layer. The review identified opportunities to improve error handling, code clarity, and efficiency.
examples/camera-app/linux/include/media-controller/default-media-controller.h
Show resolved
Hide resolved
examples/camera-app/linux/src/clusters/webrtc-provider/webrtc-provider-manager.cpp
Show resolved
Hide resolved
|
PR #39953: Size comparison from 00aa48e to b129c14 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
0eb849e to
58e4758
Compare
|
PR #39953: Size comparison from 7490ecc to 0000f3c Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
joonhaengHeo
approved these changes
Jul 11, 2025
marktrayer
approved these changes
Jul 11, 2025
pidarped
reviewed
Jul 11, 2025
| std::shared_ptr<rtc::PeerConnection> mPeerConnection; | ||
| std::shared_ptr<rtc::Track> mVideoTrack; | ||
| std::shared_ptr<rtc::Track> mAudioTrack; | ||
| std::shared_ptr<WebRTCPeerConnection> mPeerConnection; |
There was a problem hiding this comment.
Are these required to be shared_ptrs?
There was a problem hiding this comment.
Will take care of this in a follow-up PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current WebRTC implementation is tightly coupled with the libdatachannel library. This means that rtc:: types (like rtc::PeerConnection and rtc::Track) are used directly throughout the WebRTC provider manager and transport classes.
If the system were to integrate a different WebRTC stack, it would require significant effort. This is because:
To mitigate this tight coupling, we need to introduce an abstraction layer for WebRTC APIs.
Related issues
N/A
Testing
Validated by the CI