increasing coverage for src/protocols/bdx folder. #39975
Draft
+325
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
26
to
29
| TEST_F(TestTransferDiagnosticLog, TestTransferDiagnosticLog) | ||
| { | ||
|
|
||
| } |
Comment on lines
172
to
171
| TEST_F(TestTransferFacilitator, InitiatesTransfer) | ||
| { | ||
| TestInitiator initiator; | ||
|
|
||
| auto r = initiator.InitiateTransfer(&gSystemLayerAndClock, TransferRole::kSender, | ||
| TransferSession::TransferInitData(), System::Clock::Seconds16(60), System::Clock::Milliseconds32(500)); | ||
|
|
||
| ASSERT_EQ(r, CHIP_NO_ERROR); // Placeholder for actual test logic | ||
| } |
There was a problem hiding this comment.
This test case only asserts that the function returns CHIP_NO_ERROR. A unit test should verify the side effects of the function under test. For InitiateTransfer, this includes checking that a timer has been started and that a SendInit or ReceiveInit message is ready to be sent 1.
Style Guide References
Footnotes
-
Tests should assert conditions. ↩
Comment on lines
221
to
238
| TEST_F(TestTransferFacilitator, PollsForOutput) | ||
| { | ||
| TestInitiator initiator; | ||
|
|
||
| auto r = initiator.InitiateTransfer(&gSystemLayerAndClock, TransferRole::kSender, | ||
| TransferSession::TransferInitData(), System::Clock::Seconds16(60), System::Clock::Milliseconds32(500)); | ||
|
|
||
| ASSERT_EQ(r, CHIP_NO_ERROR); // Placeholder for actual test logic | ||
|
|
||
| // hook a callback to the output handler | ||
| bool outputHandled = false; | ||
| initiator.mTransferSessionOutputHandler = [&outputHandled](TransferSession::OutputEvent & event) { | ||
| 10000 | outputHandled = true; | |
| }; | ||
|
|
||
| // hook a callback to the StartTimerHook | ||
| bool timerStarted = false; | ||
| gSystemLayerAndClock.mStartTimerHook = [&timerStarted](auto, auto, void *) { | ||
| timerStarted = true; | ||
| }; | ||
|
|
||
| // Simulate a poll | ||
| initiator.PollForOutput(); | ||
|
|
||
| // Check if the poll was handled correctly | ||
| ASSERT_TRUE(outputHandled); | ||
|
|
||
| // Check if the timer was started | ||
| ASSERT_TRUE(timerStarted); | ||
| } |
There was a problem hiding this comment.
Comment on lines
252
to
270
| TEST_F(TestTransferFacilitator, TriggeringImmediatePollCallsPollForOutput) | ||
| { | ||
| TestInitiator initiator; | ||
|
|
||
| gSystemLayerAndClock.SetMonotonic(0_ms); | ||
|
|
||
| auto r = initiator.InitiateTransfer(&gSystemLayerAndClock, TransferRole::kSender, | ||
| TransferSession::TransferInitData(), System::Clock::Seconds16(60), System::Clock::Milliseconds32(500)); | ||
|
|
||
| ASSERT_EQ(r, CHIP_NO_ERROR); // Placeholder for actual test logic | ||
|
|
||
| // hook a callback to the output handler | ||
| bool outputHandled = false; | ||
| initiator.mTransferSessionOutputHandler = [&outputHandled](TransferSession::OutputEvent & event) { | ||
| outputHandled = true; | ||
| }; | ||
|
|
||
| // hook a callback to the StartTimerHook | ||
| bool timerStarted = false; | ||
| gSystemLayerAndClock.mStartTimerHook = [&timerStarted](auto, auto, void *) { | ||
| timerStarted = true; | ||
| }; | ||
|
|
||
| // Schedule an immediate poll | ||
| initiator.ScheduleImmediatePoll(); | ||
|
|
||
| // Advancing clock 1_ms triggers the immediate poll disregarding the poll frequency timer | ||
| gSystemLayerAndClock.AdvanceMonotonic(1_ms); | ||
|
|
||
| // Check if the poll was handled correctly | ||
| ASSERT_TRUE(outputHandled); | ||
|
|
||
| // Check if the timer was started | ||
| ASSERT_TRUE(timerStarted); | ||
| } |
Comment on lines
289
to
299
| TEST_F(TestTransferFacilitator, ResponderPreparesForTransfer) | ||
| { | ||
| TestResponder responder; | ||
|
|
||
| gSystemLayerAndClock.SetMonotonic(0_ms); | ||
|
|
||
| auto r = responder.PrepareForTransfer(&gSystemLayerAndClock, TransferRole::kReceiver, | ||
| TransferControlFlags::kReceiverDrive, 1024, System::Clock::Seconds16(60), System::Clock::Milliseconds32(500)); | ||
|
|
||
| EXPECT_EQ(r, CHIP_NO_ERROR); // Placeholder for actual test logic | ||
| } |
17519df to
9da2a51
Compare
|
PR #39975: Size comparison from 48704fe to 9da2a51 Full report (56 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
Increased unit tests coverage for #37247
Tests added for
src/protocols/bdx