[AVSUM] Correct the checking for running in CI #39976
Merged
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Code Review
This pull request corrects the variable used to detect if tests are running in a CI environment across three AVSUM test scripts. The change itself is correct.
My review focuses on improving the test logic for when a CI environment is detected. In all three files, the current implementation would silently skip a manual test step, which could lead to misleading test results. I've suggested changes to explicitly skip these manual steps when running in CI, which will improve the clarity and correctness of the test outcomes.
|
PR #39976: Size comparison from 48704fe to 3c5057f Full report (59 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
yufengwangca
approved these changes
Jul 11, 2025
chulspro
approved these changes
8000
Jul 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
AVSUM test scripts were not correctly checking for running in CI. This was not caught due to a lower layer problem on PIXIT value handling. This PR corrects the checks.
Testing
Using the Python runner execute AVSUM_2_2, AVSUM_2_3, and AVSUM_2_4 providing them with the PIXIT controlling value set to true and false.
Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)
See: Pull Request Guidelines