[Ameba] Update Ameba platform #39982
Open
+719
−174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added Ameba Device Info Provider implementation to support Fixed Label, User Label, Locales, and Calendar. * Moved HandleEventTrigger from header file to .cpp to allow platform implementation to override the Test Event Trigger. * Added AmebaDeviceManager to receive post-attribute change callbacks in platform applications layer. * Fixed incorrect default value retrieval for hardware version. * Added GetSoftwareVersionString to correctly retrieve the software version string. * Tidy up chipinterface.cpp
21123e7 to
e38aa0f
Compare
|
PR #39982: Size comparison from ad2e3f5 to e38aa0f Full report (59 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Jul 14, 2025
| switch (mIndex) | ||
| { | ||
| case 0: | ||
| labelPtr = "room"; |
There was a problem hiding this comment.
why do we check in such a hard-coded list?
andy31415
reviewed
Jul 14, 2025
| @@ -0,0 +1,107 @@ | |||
| /* | |||
| * | |||
| * Copyright (c) 2022 Project CHIP Authors | |||
There was a problem hiding this comment.
year is suspicious: was this copied&pasted from somewhere else? Are we able to re-use instead?
|
PR #39982: Size comparison from 1283920 to 7591506 Full report (59 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Adding of Ameba Device Info Provider
verified with chip-tool command to retrieve the correct supporting list of label-list and supported-calendar-types. Also checked with set and get for userlabel:
./chip-tool timeformatlocalization read supported-calendar-types 1 0
./chip-tool fixedlabel read label-list 1 0
./chip-tool userlabel write label-list '[{"label":"roomName", "value":"master bedroom 1"}, {"label":"orientation", "value":"east"}, {"label":"floor", "value":"2"}, {"label":"roomType", "value":"bedroom"}]' 1 0
./chip-tool userlabel read label-list 1 0
Changes for Hardware Version and Software Version String
verified with chip-tool command to obtain the default Hardware version if factory data is disabled, and default Software version string declared using predefined macros.
./chip-tool basicinformation read hardware-version 1 0
./chip-tool basicinformation read software-version-string 10
Changes for HandleEventTrigger, AmebaDeviceManager and chipinterface.cpp
verified on Ameba platform build, will also be check with CI.
purpose: Flexible handling of event on vendor application layer, similar to AmebaDeviceManager, where post attribute callback can be posted to vendor application layer to perform action required.