-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Fix SecureStateChanged event issue in the test script TC_CLCTRL_6_1 #39910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SecureStateChanged event issue in the test script TC_CLCTRL_6_1 #39910
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The code changes introduce a fix to handle out-of-order events in the TC_CLCTRL_6_1 test script. To improve maintainability, consider refactoring the duplicated event handling logic into a helper method.
PR #39910: Size comparison from b60ae1b to a62b5d4 Full report (3 builds for cc32xx, stm32)
|
PR #39910: Size comparison from b60ae1b to 05bf7f7 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #39910: Size comparison from b60ae1b to b24bbf5 Full report (13 builds for cc32xx, nrfconnect, telink)
|
b24bbf5
to
9b1c27e
Compare
PR #39910: Size comparison from 0c96632 to 9b1c27e Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #39910: Size comparison from c90dfea to d506688 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #39910: Size comparison from 43234ba to 8c5987a Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #39910: Size comparison from cb25b43 to 3d3d001 Full report (8 builds for cc32xx, nrfconnect, stm32, tizen)
|
PR #39910: Size comparison from cb25b43 to eabe7fb Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #39910: Size comparison from bde480e to 9d0813c Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Summary
This PR will fix a problem with the SecureStateChanged Event in the ClosureControl cluster. The problem was that in the test step response two events. If the MovementComplete Event comes first then the script fail. If the SecureStateChanged Event comes first the script pass.
The solution is to check the next two incoming events.
Testing
Executing the script TC_CLCTRL_6_1 against closure-app:
TC_CLCTRL_6_1.py - PASS