Matter testing framework: Fix bool-arg so it is not lower case'd #39917
+123
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the other --x-arg command line arguments resepect casing, but the bool one got lower cased because of the regex. Fixing this and adding a test to ensure all the arg types come through properly.
There was a problem hiding this comment.
Code Review
The pull request fixes an issue where boolean arguments in the Python matter testing framework were being converted to lowercase, causing incorrect parsing. The fix involves modifying the regex in bool_named_arg to correctly handle boolean values with different casing and adding a unit test to verify the fix.
src/python_testing/matter_testing_infrastructure/chip/testing/matter_testing.py
Outdated
Show resolved
Hide resolved
marktrayer
approved these changes
Jul 10, 2025
andy31415
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the argument parsing for boolean arguments in the python matter testing framework. These were all getting converted to lower case.
All the other --x-arg command line arguments respect casing, but the bool one got lower cased because of the regex. Fixing this and adding a test to ensure all the arg types come through properly.
Related issues
#39914
Testing
Please see attached unit test
Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)
See: Pull Request Guidelines