Label override for DM file updates #39919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Code Review
The pull request introduces a label override for DM file updates, allowing structural changes without requiring a CI override. The review focuses on ensuring the correctness of the changes made to the XML files, specifically suggesting the use of condition instead of feature where appropriate.
|
PR #39919: Size comparison from 5dc7824 to e781d14 Full report (11 builds for cc13x4_26x4, cc32xx, qpg, stm32, tizen)
|
|
PR #39919: Size comparison from 5dc7824 to 2f487fb Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
This reverts commit e781d14. This was just added as a CI test, don't want these for real in this PR.
kiel-apple
approved these changes
Jul 10, 2025
|
PR #39919: Size comparison from 777d399 to 5dbe1b1 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
ReneJosefsen
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I thought I was done making additions to the data model files, but some of the other ones need a fix up, and I don't want to have to keep bugging the TT leads for a CI override. Instead adding a label that indicates the changes to the DM files are structural and not tied to an update of the spec sha or scraper (ex adding an override or additional files from the scraping script)
Related issues
None
Testing
Testing in CI