Mypy conformance for FabricAdmin and CertificateAuthority #39920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Code Review
This pull request improves mypy conformance for FabricAdmin and CertificateAuthority by adding Optional to type hints where appropriate, which is a good improvement. The changes look solid. I've only found a minor typo in a docstring that should be corrected.
| ''' Initializes the manager. | ||
|
|
||
| chipStack: Reference to a chip.ChipStack object that is used to initialize | ||
| CertificateAuthority instances. | ||
|
|
||
| persistentStorage: If provided, over-rides the default instance in the provided chipStack | ||
| persistentStorage: And optional reference to persistentStorage, if provided, |
There was a problem hiding this comment.
There's a typo in the docstring. "And" should be "An".1
Style Guide References
Suggested change
| persistentStorage: And optional reference to persistentStorage, if provided, | |
| persistentStorage: An optional reference to persistentStorage, if provided, |
Footnotes
|
PR #39920: Size comparison from 5dc7824 to 5669221 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make whl files conformant to mypy
Search in build files *py files wich make the whl files.
grep -i ".*\.py" ./src/controller/python/BUILD.gn | grep -v py_scripts > files_mypy.txtFound several py files which make the whl file and evaluate them with mypy.
cat files_mypy.txt | grep -v "clusters/Objects.py" | xargs -I {} mypy --config-file=src/python_testing/matter_testing_infrastructure/mypy.ini {} > mypy_whl.logClean the results:
cat mypy_results.log | sort | uniq | grep -iv "success" > mypy_results_filtered.txtFind unique files to work on this issue:
cat mypy_results_filtered.txt | cut -d ":" -f1 | uniq > my_py_results_filtered_affected_files.pyIn this PR is going to cover the following files as the first part:
Related issues
#37750
Testing
Verify the files with mypy and confirm the file does not contain issues.