-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Treat examples/darwin-framework-tool as "darwin" code for review policy purposes. #39926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treat examples/darwin-framework-tool as "darwin" code for review policy purposes. #39926
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to update the review policy to treat examples/darwin-framework-tool
as Darwin-specific code. The changes correctly add this path to the required review group for Apple reviewers and exclude it from the general review group.
However, I've identified a critical syntax error in the YAML file for the inclusion rule which will likely cause CI to fail. I've provided a suggestion to fix it. The change to the exclusion rule is correct.
PR #39926: Size comparison from 34d3e1e to 6685558 Full report (45 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, nrfconnect, psoc6, qpg, stm32, telink, tizen)
|
PR #39926: Size comparison from 34d3e1e to 3de16cd Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Summary
Use the same policy for
examples/darwin-framework-tool
as we do forsrc/darwin
andsrc/platform/Darwin
.Testing
See how PRs merge or not.