Fix Groups implementation #2197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to pass the new G 2.2 python test
There was a problem hiding this comment.
Code Review
The pull request fixes an issue in the Groups implementation to pass the new G 2.2 python test. It includes changes to GroupKeyManagementServer.ts to prevent exceeding the maximum number of groups per fabric and to correctly remove endpoints from groups. It also includes changes to GroupsServer.ts to import InternalError from the correct location and adjust the order of code.
packages/node/src/behaviors/group-key-management/GroupKeyManagementServer.ts
Outdated
Show resolved
Hide resolved
…ementServer.ts Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
lauckhart
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to pass the new G 2.2 python test