8000 Fix the typing for handleMovement in WC Server by Apollon77 · Pull Request #2201 · project-chip/matter.js · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix the typing for handleMovement in WC Server #2201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2025
Merged

Fix the typing for handleMovement in WC Server #2201

merged 1 commit into from
Jun 27, 2025

Conversation

Apollon77
Copy link
Collaborator

No description provided.

@pullapprove pullapprove bot requested review from lauckhart, turon and woody-apple June 27, 2025 06:49
gemini-code-assist[bot]
gemini-code-assist bot reviewed Jun 27, 2025
View reviewed changes
Copy link
Contributor
@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The code changes update the return type of the handleMovement function in WindowCoveringServer.ts to MaybePromise and remove the async keyword. This ensures that the function can handle both synchronous and asynchronous operations.

@Apollon77 Apollon77 added the automerge Set this label if the PR is ready to automatically merged after approval label Jun 27, 2025
@mergify mergify bot merged commit e11f4de into main Jun 27, 2025
59 checks passed
@mergify mergify bot deleted the wc-type-fix branch June 27, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

@lauckhart lauckhart Awaiting requested review from lauckhart

@turon turon Awaiting requested review from turon

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
automerge Set this label if the PR is ready to automatically merged after approval review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Apollon77 @lauckhart
0