This repository was archived by the owner on Feb 27, 2023. It is now read-only.
Envoy: add envoy-admin volume, update to 1.19.1 #430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the envoy-admin emptyDir volume to the Envoy daemon set and updates the Envoy version to 1.19.1 to match projectcontour/contour. Closes projectcontour#423. Signed-off-by: Steve Kriss <krisss@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #430 +/- ##
==========================================
- Coverage 80.06% 77.67% -2.39%
==========================================
Files 29 29
Lines 2222 2235 +13
==========================================
- Hits 1779 1736 -43
- Misses 329 366 +37
- Partials 114 133 +19
Continue to review full report at Codecov.
|
sunjayBhatia
approved these changes
Aug 25, 2021
nak3
approved these changes
Aug 26, 2021
nak3
reviewed
Aug 26, 2021
| VolumeMounts: []corev1.VolumeMount{ | ||
| { | ||
| Name: envoyAdminVolName, | ||
| MountPath: filepath.Join("/", envoyAdminVolMntDir), |
There was a problem hiding this comment.
I thought envoyAdminVolMntDir = "/admin" instead of using filepath.Join is fine but using filepath.Join will be consistent with other VolumeMounts setting.
There was a problem hiding this comment.
Yeah, I just left it that way for consistency with other volume mounts. They could all drop the filepath.Join though.
youngnick
approved these changes
Aug 26, 2021
skriss
added a commit
to skriss/contour-operator
that referenced
this pull request
Aug 26, 2021
Adds the envoy-admin emptyDir volume to the Envoy daemon set and updates the Envoy version to 1.19.1 to match projectcontour/contour. Closes projectcontour#423. Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss
added a commit
to skriss/contour-operator
that referenced
this pull request
Aug 26, 2021
Cherry-pick of projectcontour#430: Adds the envoy-admin emptyDir volume to the Envoy daemon set and updates the Envoy version to 1.19.1 to match projectcontour/contour. Signed-off-by: Steve Kriss <krisss@vmware.com>
skriss
added a commit
that referenced
this pull request
Aug 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the envoy-admin emptyDir volume to the Envoy
daemon set and updates the Envoy version to 1.19.1
to match projectcontour/contour.
Closes #423.
Signed-off-by: Steve Kriss krisss@vmware.com