Add support for Envoy CustomResponse LocalReply in HTTPProxy CRDs #6974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change enables Contour HTTPProxy CRDs to support matching internal response codes and replacing them with custom user-provided responses. This is particularly useful for cases where pods selected by a service are not-ready, allowing custom pages to be shown instead of the default 503 Unhealthy Upstream response. Fixes projectcontour#320 Signed-off-by: Jonathan Siegel <248302+usiegj00@users.noreply.github.com>
|
Hi @usiegj00! Welcome to our community and thank you for opening your first Pull Request. Someone will review it soon. Thank you for committing to making Contour better. You can also join us on our mailing list and in our channel in the Kubernetes Slack Workspace |
Signed-off-by: Jonathan Siegel <248302+usiegj00@users.noreply.github.com>
6151d8c to
2e20bb4
Compare
|
Hi @usiegj00, thank you for your contribution! Could you please add the changelog to the file |
Signed-off-by: Jonathan Siegel <248302+usiegj00@users.noreply.github.com>
Signed-off-by: Jonathan Siegel <248302+usiegj00@users.noreply.github.com>
|
You can likely resolve the code generation error by running |
… explicit with a new helper. Signed-off-by: Jonathan Siegel <248302+usiegj00@users.noreply.github.com>
|
The Contour project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to the #contour channel in the Kubernetes Slack |
|
Hiya—I think I've addressed all the issues now. Let me know if I should
make any other changes.
…On Sat, Apr 12, 2025 at 9:28 AM, github-actions[bot] < ***@***.***> wrote:
The Contour project currently lacks enough contributors to adequately
respond to all PRs.
This bot triages PRs according to the following rules:
- After 14d of inactivity, lifecycle/stale is applied
- After 30d of inactivity since lifecycle/stale was applied, the PR is
closed
You can:
- *Ensure your PR is passing all CI checks.* PRs that are fully green
are more likely to be reviewed. If you are having trouble with CI checks,
reach out to the #contour channel in the Kubernetes Slack workspace.
- Mark this PR as fresh by commenting or pushing a commit
- Close this PR
- Offer to help out with triage
Please send feedback to the #contour channel in the Kubernetes Slack
—
Reply to this email directly, view it on GitHub
<#6974 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB4T3QSCLSEJA5AAOCKCAT2ZBMZJAVCNFSM6AAAAABZ543AUOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOJYGI2TINBSGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
*github-actions[bot]* left a comment (projectcontour/contour#6974)
<#6974 (comment)>
The Contour project currently lacks enough contributors to adequately
respond to all PRs.
This bot triages PRs according to the following rules:
- After 14d of inactivity, lifecycle/stale is applied
- After 30d of inactivity since lifecycle/stale was applied, the PR is
closed
You can:
- *Ensure your PR is passing all CI checks.* PRs that are fully green
are more likely to be reviewed. If you are having trouble with CI checks,
reach out to the #contour channel in the Kubernetes Slack workspace.
- Mark this PR as fresh by commenting or pushing a commit
- Close this PR
- Offer to help out with triage
Please send feedback to the #contour channel in the Kubernetes Slack
—
Reply to this email directly, view it on GitHub
<#6974 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAB4T3QSCLSEJA5AAOCKCAT2ZBMZJAVCNFSM6AAAAABZ543AUOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOJYGI2TINBSGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
…e limit Fix the ResponseOverridePolicy implementation to correctly handle response body content in HTTP error responses. Standardize RuntimeKey handling to use empty strings with consistent commenting. Add a 4KB size limit to Inline response body field to balance expressive content with avoiding CRD bloat. Fixes projectcontour#6974 Signed-off-by: Jonathan Siegel <248302+usiegj00@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6974 +/- ##
==========================================
+ Coverage 80.72% 81.25% +0.53%
==========================================
Files 131 130 -1
Lines 19868 19918 +50
==========================================
+ Hits 16039 16185 +146
+ Misses 3537 3446 -91
+ Partials 292 287 -5
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enables Contour HTTPProxy CRDs to support matching internal response codes and replacing them with custom user-provided responses. This is particularly useful for cases where pods selected by a service are not-ready, allowing custom pages to be shown instead of the default 503 Unhealthy Upstream response.
Fixes #320