This repository was archived by the owner on Feb 27, 2023. It is now read-only.
discovery: don't make lb name part of the k8s name #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Brand <alexbrand09@gmail.com>
stevesloka
reviewed
Sep 18, 2018
discovery/pkg/openstack/translate.go
Outdated
| func serviceName(lb loadbalancers.LoadBalancer) string { | ||
| lbName := lb.ID | ||
| if lb.Name != "" { | ||
| lbName = fmt.Sprintf("%s-%s", lb.Name, lb.ID) | ||
| } | ||
| return strings.ToLower(lbName) |
There was a problem hiding this comment.
Is the ID ever upper case to need the ToLower? Also, maybe could just simplify this to return: strings.ToLower(lb.ID)
There was a problem hiding this comment.
I have seen uppercase UUIDs in the past, so left the ToLower in there for good measure.
I'll simplify the code down to that single line.
Signed-off-by: Alexander Brand <alexbrand09@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the openstack translation process to only use the load balancer's ID as the service/endpoint name. The load balancer name is still available as a label on the service.
Fixes #216