8000 Removing pylint common by carlio · Pull Request #273 · prospector-dev/prospector · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Removing pylint common #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 31, 2018
Merged

Removing pylint common #273

merged 4 commits into from
Jul 31, 2018

Conversation

carlio
Copy link
Member
@carlio carlio commented Jul 31, 2018

pylint-common is an unecessary dependency and adds additional 'cogs' to keep up to date with. It only has one augmentation which if necessary could be moved into prospector directly,

@coveralls
Copy link
coveralls commented Jul 31, 2018

Pull Request Test Coverage Report for Build 627

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 272 unchanged lines in 19 files lost coverage.
  • Overall coverage increased (+1.2%) to 77.592%

Files with Coverage Reduction New Missed Lines %
prospector/tools/pylint/init.py 1 77.24%
prospector/formatters/text.py 1 64.29%
prospector/message.py 4 79.66%
prospector/encoding.py 5 66.67%
prospector/finder.py 6 83.59%
prospector/tools/pylint/linter.py 7 64.71%
prospector/tools/pylint/collector.py 9 86.21%
prospector/tools/pep257/init.py 10 80.65%
prospector/tools/pylint/indent_checker.py 11 80.77%
prospector/postfilter.py 11 95.0%
Totals Coverage Status
Change from base Build 620: 1.2%
Covered Lines: 1534
Relevant Lines: 1977

💛 - Coveralls

@carlio carlio merged commit cc5b9f1 into master Jul 31, 2018
@chocoelho chocoelho deleted the removing-pylint-common branch June 29, 2020 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0